From: Tejun Heo <tj@kernel.org>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: linux-ide@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Lior Amsalem <alior@marvell.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>
Subject: Re: [PATCH v2] ATA: sata_mv: Remove unneeded CONFIG_HAVE_CLK ifdefs
Date: Tue, 30 Jul 2013 09:04:11 -0400 [thread overview]
Message-ID: <20130730130411.GC12016@htj.dyndns.org> (raw)
In-Reply-To: <1375152363-3451-1-git-send-email-ezequiel.garcia@free-electrons.com>
On Mon, Jul 29, 2013 at 11:46:03PM -0300, Ezequiel Garcia wrote:
> If CONFIG_HAVE_CLK is not selected, then all the clk API turn out
> into no-ops. In other words, there's no need to have the ifdefs.
>
> The only side-effect of this patch is the extra tiny kmalloc,
> but that's not enough reason to have such ugly ifdefs all around
> the code.
>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Applied to libata/for-3.12 with Andrew's comment suggestion applied
and acked-by added.
Thanks.
--
tejun
next prev parent reply other threads:[~2013-07-30 13:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 2:46 [PATCH v2] ATA: sata_mv: Remove unneeded CONFIG_HAVE_CLK ifdefs Ezequiel Garcia
2013-07-30 7:05 ` Andrew Lunn
2013-07-30 13:04 ` Tejun Heo [this message]
2013-07-30 13:16 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730130411.GC12016@htj.dyndns.org \
--to=tj@kernel.org \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=linux-ide@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).