From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v2] ATA: sata_mv: Remove unneeded CONFIG_HAVE_CLK ifdefs Date: Tue, 30 Jul 2013 09:04:11 -0400 Message-ID: <20130730130411.GC12016@htj.dyndns.org> References: <1375152363-3451-1-git-send-email-ezequiel.garcia@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-qc0-f173.google.com ([209.85.216.173]:60754 "EHLO mail-qc0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752968Ab3G3NEP (ORCPT ); Tue, 30 Jul 2013 09:04:15 -0400 Received: by mail-qc0-f173.google.com with SMTP id z10so1556102qcx.32 for ; Tue, 30 Jul 2013 06:04:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1375152363-3451-1-git-send-email-ezequiel.garcia@free-electrons.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Ezequiel Garcia Cc: linux-ide@vger.kernel.org, Andrew Lunn , Lior Amsalem , Thomas Petazzoni , Gregory Clement On Mon, Jul 29, 2013 at 11:46:03PM -0300, Ezequiel Garcia wrote: > If CONFIG_HAVE_CLK is not selected, then all the clk API turn out > into no-ops. In other words, there's no need to have the ifdefs. > > The only side-effect of this patch is the extra tiny kmalloc, > but that's not enough reason to have such ugly ifdefs all around > the code. > > Signed-off-by: Ezequiel Garcia Applied to libata/for-3.12 with Andrew's comment suggestion applied and acked-by added. Thanks. -- tejun