From: Tejun Heo <tj@kernel.org>
To: Marc C <marc.ceeeee@gmail.com>
Cc: linux-ide@vger.kernel.org, sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCH v3 1/3] libata: Populate host-to-device FIS "auxiliary" field
Date: Fri, 9 Aug 2013 10:03:58 -0400 [thread overview]
Message-ID: <20130809140358.GA20515@mtj.dyndns.org> (raw)
In-Reply-To: <1376023752-3105-2-git-send-email-marc.ceeeee@gmail.com>
On Thu, Aug 08, 2013 at 09:49:10PM -0700, Marc C wrote:
> From: Marc Carino <marc.ceeeee@gmail.com>
>
> SATA 3.1 added an "auxiliary" field to the host-to-device FIS.
>
> Since there is no analog between the new field and the ATA
> taskfile, a new element was added to 'struct ata_queued_cmd."
Ummm... I'm sorry but I'm gonna do 180 from Sergei on this one. The
auxiliary field is part of ata taskfile for all intents and purposes.
FIS is the new command structure anyway and struct ata_taskfile proper
should be able to describe the command with ata_queuedcmd providing
the surrounding context. The argument that ata_taskfile shouldn't
contain anything which wasn't in PATA taskfile is bogus as it already
contains ATA_TFLAG_*.
So, please put the aux field into ata_taskfile. That's where it
belongs.
Thanks.
--
tejun
next prev parent reply other threads:[~2013-08-09 14:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 4:49 [PATCH v3 0/3] Introduce new SATA queued commands Marc C
2013-08-09 4:49 ` [PATCH v3 1/3] libata: Populate host-to-device FIS "auxiliary" field Marc C
2013-08-09 14:03 ` Tejun Heo [this message]
2013-08-09 14:36 ` Sergei Shtylyov
2013-08-09 14:53 ` Tejun Heo
2013-08-09 21:39 ` Sergei Shtylyov
2013-08-09 21:51 ` Tejun Heo
2013-08-09 22:17 ` Sergei Shtylyov
2013-08-09 22:26 ` Tejun Heo
2013-08-10 21:59 ` Sergei Shtylyov
2013-08-12 13:58 ` Tejun Heo
2013-08-09 21:24 ` Sergei Shtylyov
2013-08-09 14:17 ` Sergei Shtylyov
2013-08-09 14:29 ` Sergei Shtylyov
2013-08-09 14:26 ` Sergei Shtylyov
2013-08-09 4:49 ` [PATCH v3 2/3] libata: Add support for SEND/RECEIVE FPDMA QUEUED Marc C
2013-08-09 14:05 ` Tejun Heo
2013-08-10 2:10 ` Marc C
2013-08-09 4:49 ` [PATCH v3 3/3] libata: Add support for queued DSM TRIM Marc C
2013-08-09 14:07 ` Sergei Shtylyov
2013-08-09 14:08 ` Tejun Heo
2013-08-10 2:14 ` Marc C
2013-08-10 15:11 ` Tejun Heo
[not found] <52059FBF.7050303@gmail.com>
2013-08-10 2:06 ` [PATCH v3 1/3] libata: Populate host-to-device FIS "auxiliary" field Marc C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130809140358.GA20515@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=marc.ceeeee@gmail.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).