From: 'Tejun Heo' <tj@kernel.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/2] ata: pata_samsung_cf: add missing __iomem annotation
Date: Fri, 9 Aug 2013 10:13:06 -0400 [thread overview]
Message-ID: <20130809141306.GD20515@mtj.dyndns.org> (raw)
In-Reply-To: <000101ce94c2$52ad79f0$f8086dd0$@samsung.com>
On Fri, Aug 09, 2013 at 02:35:57PM +0900, Jingoo Han wrote:
> From e15fc1811b2ce01358de00c34e4a69a52bb1e9c5 Mon Sep 17 00:00:00 2001
> From: Jingoo Han <jg1.han@samsung.com>
> Date: Fri, 9 Aug 2013 14:24:35 +0900
> Subject: [PATCH 2/2] ata: pata_samsung_cf: add missing __iomem annotation
>
> Added missing __iomem annotation and staticized local symbol
> in order to fix the following sparse warnings:
>
> drivers/ata/pata_samsung_cf.c:244:14: warning: symbol 'pata_s3c_data_xfer' was not declared. Should it be static?
> drivers/ata/pata_samsung_cf.c:423:20: warning: incorrect type in argument 1 (different address spaces)
> drivers/ata/pata_samsung_cf.c:423:20: expected void const volatile [noderef] <asn:2>*addr
> drivers/ata/pata_samsung_cf.c:423:20: got void *
> drivers/ata/pata_samsung_cf.c:425:9: warning: incorrect type in argument 2 (different address spaces)
> drivers/ata/pata_samsung_cf.c:425:9: expected void volatile [noderef] <asn:2>*addr
> drivers/ata/pata_samsung_cf.c:425:9: got void *
> drivers/ata/pata_samsung_cf.c:448:37: warning: incorrect type in argument 1 (different address spaces)
> drivers/ata/pata_samsung_cf.c:448:37: expected void *s3c_ide_regbase
> drivers/ata/pata_samsung_cf.c:448:37: got void [noderef] <asn:2>*ide_addr
> drivers/ata/pata_samsung_cf.c:463:37: warning: incorrect type in argument 1 (different address spaces)
> drivers/ata/pata_samsung_cf.c:463:37: expected void *s3c_ide_regbase
> drivers/ata/pata_samsung_cf.c:463:37: got void [noderef] <asn:2>*ide_addr
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied to libata/for-3.12.
Thanks.
--
tejun
prev parent reply other threads:[~2013-08-09 14:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 5:35 [PATCH 2/2] ata: pata_samsung_cf: add missing __iomem annotation Jingoo Han
2013-08-09 14:13 ` 'Tejun Heo' [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130809141306.GD20515@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=jg1.han@samsung.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).