* [PATCH 1/2] ata: pata_arasan: Staticize local symbols
@ 2013-08-09 5:35 Jingoo Han
2013-08-09 5:41 ` Viresh Kumar
2013-08-09 14:13 ` 'Tejun Heo'
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-08-09 5:35 UTC (permalink / raw)
To: 'Tejun Heo'; +Cc: linux-ide, Viresh Kumar, Jingoo Han
These local symbols are used only in this file.
Fix the following sparse warnings:
drivers/ata/pata_arasan_cf.c:657:6: warning: symbol 'arasan_cf_error_handler' was not declared. Should it be static?
drivers/ata/pata_arasan_cf.c:686:14: warning: symbol 'arasan_cf_qc_issue' was not declared. Should it be static?
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/ata/pata_arasan_cf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
index 848ed32..853f610 100644
--- a/drivers/ata/pata_arasan_cf.c
+++ b/drivers/ata/pata_arasan_cf.c
@@ -654,7 +654,7 @@ static void arasan_cf_freeze(struct ata_port *ap)
ata_sff_freeze(ap);
}
-void arasan_cf_error_handler(struct ata_port *ap)
+static void arasan_cf_error_handler(struct ata_port *ap)
{
struct arasan_cf_dev *acdev = ap->host->private_data;
@@ -683,7 +683,7 @@ static void arasan_cf_dma_start(struct arasan_cf_dev *acdev)
ata_sff_queue_work(&acdev->work);
}
-unsigned int arasan_cf_qc_issue(struct ata_queued_cmd *qc)
+static unsigned int arasan_cf_qc_issue(struct ata_queued_cmd *qc)
{
struct ata_port *ap = qc->ap;
struct arasan_cf_dev *acdev = ap->host->private_data;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] ata: pata_arasan: Staticize local symbols
2013-08-09 5:35 [PATCH 1/2] ata: pata_arasan: Staticize local symbols Jingoo Han
@ 2013-08-09 5:41 ` Viresh Kumar
2013-08-09 14:13 ` 'Tejun Heo'
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2013-08-09 5:41 UTC (permalink / raw)
To: Jingoo Han; +Cc: Tejun Heo, linux-ide
On Fri, Aug 9, 2013 at 11:05 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> These local symbols are used only in this file.
> Fix the following sparse warnings:
>
> drivers/ata/pata_arasan_cf.c:657:6: warning: symbol 'arasan_cf_error_handler' was not declared. Should it be static?
> drivers/ata/pata_arasan_cf.c:686:14: warning: symbol 'arasan_cf_qc_issue' was not declared. Should it be static?
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/ata/pata_arasan_cf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] ata: pata_arasan: Staticize local symbols
2013-08-09 5:35 [PATCH 1/2] ata: pata_arasan: Staticize local symbols Jingoo Han
2013-08-09 5:41 ` Viresh Kumar
@ 2013-08-09 14:13 ` 'Tejun Heo'
1 sibling, 0 replies; 3+ messages in thread
From: 'Tejun Heo' @ 2013-08-09 14:13 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-ide, Viresh Kumar
On Fri, Aug 09, 2013 at 02:35:00PM +0900, Jingoo Han wrote:
> These local symbols are used only in this file.
> Fix the following sparse warnings:
>
> drivers/ata/pata_arasan_cf.c:657:6: warning: symbol 'arasan_cf_error_handler' was not declared. Should it be static?
> drivers/ata/pata_arasan_cf.c:686:14: warning: symbol 'arasan_cf_qc_issue' was not declared. Should it be static?
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied to libata/for-3.12.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-09 14:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-09 5:35 [PATCH 1/2] ata: pata_arasan: Staticize local symbols Jingoo Han
2013-08-09 5:41 ` Viresh Kumar
2013-08-09 14:13 ` 'Tejun Heo'
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).