Re: [PATCH v4 2/3] libata: Add support for SEND/RECEIVE FPDMA QUEUED

[Tejun Heo <tj@kernel.org>]

Hello, Marc.

On Fri, Aug 23, 2013 at 02:40:46AM -0700, Marc C wrote:
> From: Marc Carino <marc.ceeeee@gmail.com>
> 
> Add support for the following ATA opcodes, which are present
> in SATA 3.1 and T13 ATA ACS-3:
> 
>         SEND FPDMA QUEUED
>         RECEIVE FPDMA QUEUED
> 
> Signed-off-by: Marc Carino <marc.ceeeee@gmail.com>
> ---
>  drivers/ata/libata-core.c | 20 ++++++++++++++++++++
>  include/linux/ata.h       | 23 +++++++++++++++++++++++
>  include/linux/libata.h    |  4 ++++
>  3 files changed, 47 insertions(+)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 9062aa0..34ccadb 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -2141,6 +2141,26 @@ static int ata_dev_config_ncq(struct ata_device *dev,
>  	else
>  		snprintf(desc, desc_sz, "NCQ (depth %d/%d)%s", hdepth,
>  			ddepth, aa_desc);
> +
> +	if ((ap->flags & ATA_FLAG_FPDMA_AUX) &&
> +		ata_id_has_ncq_send_and_recv(dev->id)) {
> +		err_mask = ata_read_log_page(dev,
> +					     ATA_LOG_NCQ_SEND_RECV,
> +					     0,
> +					     ap->sector_buf,
> +					     1);

Can you please fill to 80 col instead?  I know the other invocation is
breaking line for each argument but let's not spread that.

> +		if (err_mask) {
> +			ata_dev_dbg(dev,
> +				    "failed to get NCQ Send/Recv Log "
> +				    "Emask 0x%x\n",

And no need to break line for format strings.

> +static inline bool ata_id_has_ncq_send_and_recv(const u16 *id)
> +{
> +	if (id[ATA_ID_SATA_CAPABILITY_2] & BIT(6))
> +		return true;
> +	return false;
> +}

 return id[ATA_ID_SATA_CAPABILITY_2] & BIT(6);

thanks.

-- 
tejun