From: Tejun Heo <tj@kernel.org>
To: Marc C <marc.ceeeee@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH v4 3/3] libata: Add support for queued DSM TRIM
Date: Fri, 23 Aug 2013 12:07:19 -0400 [thread overview]
Message-ID: <20130823160719.GI3277@htj.dyndns.org> (raw)
In-Reply-To: <1377250847-24132-4-git-send-email-marc.ceeeee@gmail.com>
On Fri, Aug 23, 2013 at 02:40:47AM -0700, Marc C wrote:
> +static inline int ata_fpdma_dsm_supported(struct ata_device *dev)
bool?
> +{
> + if ((dev->flags & ATA_DFLAG_NCQ_SEND_RECV) &&
> + (dev->ncq_send_recv_cmds[ATA_LOG_NCQ_SEND_RECV_DSM_OFFSET] &
> + ATA_LOG_NCQ_SEND_RECV_DSM_TRIM)) {
> + return 1;
> + } else {
> + return 0;
> + }
And again, you can just use a return statement.
--
tejun
next prev parent reply other threads:[~2013-08-23 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 9:40 [PATCH v4 0/3] Introduce new SATA queued commands Marc C
2013-08-23 9:40 ` [PATCH v4 1/3] libata: Populate host-to-device FIS "auxiliary" field Marc C
2013-08-23 12:27 ` Sergei Shtylyov
2013-08-23 9:40 ` [PATCH v4 2/3] libata: Add support for SEND/RECEIVE FPDMA QUEUED Marc C
2013-08-23 12:43 ` Sergei Shtylyov
2013-08-23 16:06 ` Tejun Heo
2013-08-23 9:40 ` [PATCH v4 3/3] libata: Add support for queued DSM TRIM Marc C
2013-08-23 16:07 ` Tejun Heo [this message]
2013-08-23 16:08 ` [PATCH v4 0/3] Introduce new SATA queued commands Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130823160719.GI3277@htj.dyndns.org \
--to=tj@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=marc.ceeeee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).