* [PATCH] libata: bugfix: Remove __le32 in ata_tf_to_fis
@ 2013-09-01 15:59 Marc C
2013-09-03 14:39 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Marc C @ 2013-09-01 15:59 UTC (permalink / raw)
To: tj, linux-ide; +Cc: Marc Carino
From: Marc Carino <marc.ceeeee@gmail.com>
The endianness attribute on the 'aux' local variable is a wrong, and
can lead to issues on big-endian machines,
Signed-off-by: Marc Carino <marc.ceeeee@gmail.com>
---
drivers/ata/libata-core.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index a044be9..83b1a9f 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -546,8 +546,6 @@ int atapi_cmd_type(u8 opcode)
*/
void ata_tf_to_fis(const struct ata_taskfile *tf, u8 pmp, int is_cmd, u8 *fis)
{
- const __le32 aux = cpu_to_le32(tf->auxiliary);
-
fis[0] = 0x27; /* Register - Host to Device FIS */
fis[1] = pmp & 0xf; /* Port multiplier number*/
if (is_cmd)
@@ -571,10 +569,10 @@ void ata_tf_to_fis(const struct ata_taskfile *tf, u8 pmp, int is_cmd, u8 *fis)
fis[14] = 0;
fis[15] = tf->ctl;
- fis[16] = aux & 0xff;
- fis[17] = (aux >> 8) & 0xff;
- fis[18] = (aux >> 16) & 0xff;
- fis[19] = (aux >> 24) & 0xff;
+ fis[16] = tf->auxiliary & 0xff;
+ fis[17] = (tf->auxiliary >> 8) & 0xff;
+ fis[18] = (tf->auxiliary >> 16) & 0xff;
+ fis[19] = (tf->auxiliary >> 24) & 0xff;
}
/**
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-03 14:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-01 15:59 [PATCH] libata: bugfix: Remove __le32 in ata_tf_to_fis Marc C
2013-09-03 14:39 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).