From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 3/4] AHCI: Conserve interrupts with pci_enable_msi_block_part() interface Date: Tue, 3 Sep 2013 14:27:31 -0400 Message-ID: <20130903182731.GA27092@mtj.dyndns.org> References: <3bb1b4375655ecfde5017cc70973d078f2434d5d.1378111919.git.agordeev@redhat.com> <20130903141824.GD10522@htj.dyndns.org> <20130903161906.GC14221@dhcp-26-207.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20130903161906.GC14221@dhcp-26-207.brq.redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-pci@vger.kernel.org, linux-ide@vger.kernel.org, Ingo Molnar , Joerg Roedel , Jan Beulich , Bjorn Helgaas List-Id: linux-ide@vger.kernel.org Hello, On Tue, Sep 03, 2013 at 06:19:06PM +0200, Alexander Gordeev wrote: > We must enable maximum possible number of MSIs - the one reported in > Multiple Message Capable register. Otherwise ICH device will fallback > to MRSM. IOW, if the result of roundup_pow_of_two(n_ports) is not what > in Multiple Message Capable register (i.e. as roundup_pow_of_two(6) vs 16) > ICH will enforce MRSM mode. Hmmm... I think the interface in general is pretty messy. Wouldn't it be much cleaner to have a separate function to query MSICAP and let the function just return success / failure? Thanks. -- tejun