From: Tejun Heo <tj@kernel.org>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
linux-pci@vger.kernel.org, linux-ide@vger.kernel.org,
Ingo Molnar <mingo@kernel.org>, Joerg Roedel <joro@8bytes.org>,
Jan Beulich <JBeulich@suse.com>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH 3/4] AHCI: Conserve interrupts with pci_enable_msi_block_part() interface
Date: Wed, 4 Sep 2013 14:51:16 -0400 [thread overview]
Message-ID: <20130904185116.GF26609@mtj.dyndns.org> (raw)
In-Reply-To: <20130904184715.GA24341@dhcp-26-207.brq.redhat.com>
On Wed, Sep 04, 2013 at 08:47:16PM +0200, Alexander Gordeev wrote:
> On Wed, Sep 04, 2013 at 02:06:07PM -0400, Tejun Heo wrote:
> > I don't think it's necessary / a good idea to try to support
> > everything. Just following the spec would be fine. If that doesn't
> > work for too many devices, maybe just do one fallback?
>
> Calling pci_enable_msi_block_part() in a loop may seem not that terrible
> if you think of the original interface - pci_enable_msi_block(). If we
> were to enable multiple MSIs using that one we still had to use it pretty
> much the same way ;)
I don't know. The thing is, do we even want to meddle with
controllers which only accept a value which isn't the value specified
in the spec or the maximum value described as supported? It's icky
and we are far better of playing it safe. This has the possibility of
breaking boot on many configurations.
Thanks.
--
tejun
next prev parent reply other threads:[~2013-09-04 18:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 8:59 [PATCH 0/4] AHCI: Conserve interrupts with pci_enable_msi_block_part() interface Alexander Gordeev
2013-09-02 8:59 ` [PATCH 1/4] PCI/MSI: Introduce " Alexander Gordeev
2013-09-03 14:19 ` Tejun Heo
2013-09-02 9:00 ` [PATCH 2/4] MSI/x86: Support " Alexander Gordeev
2013-09-03 13:32 ` Tejun Heo
2013-09-02 9:00 ` [PATCH 3/4] AHCI: Conserve interrupts with " Alexander Gordeev
2013-09-03 14:18 ` Tejun Heo
2013-09-03 16:19 ` Alexander Gordeev
2013-09-03 18:27 ` Tejun Heo
2013-09-04 7:22 ` Alexander Gordeev
2013-09-04 14:17 ` [PATCH v2 " Alexander Gordeev
2013-09-04 14:55 ` [PATCH " Tejun Heo
2013-09-04 16:14 ` Alexander Gordeev
2013-09-04 18:06 ` Tejun Heo
2013-09-04 18:47 ` Alexander Gordeev
2013-09-04 18:51 ` Tejun Heo [this message]
2013-09-02 9:00 ` [PATCH 4/4] PCI/MSI: Get rid of pci_enable_msi_block_auto() interface Alexander Gordeev
2013-09-03 7:58 ` [PATCH v2 " Alexander Gordeev
2013-09-03 13:55 ` [PATCH 0/4] AHCI: Conserve interrupts with pci_enable_msi_block_part() interface Tejun Heo
2013-09-03 14:09 ` Tejun Heo
2013-09-04 12:32 ` Alexander Gordeev
2013-09-04 14:57 ` Tejun Heo
2013-09-03 14:57 ` Alexander Gordeev
2013-09-03 16:24 ` Tejun Heo
2013-09-04 8:06 ` Alexander Gordeev
2013-09-04 15:02 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904185116.GF26609@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=JBeulich@suse.com \
--cc=agordeev@redhat.com \
--cc=bhelgaas@google.com \
--cc=joro@8bytes.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).