From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface Date: Mon, 9 Sep 2013 11:37:54 -0400 Message-ID: <20130909153754.GG25434@htj.dyndns.org> References: <20130905150259.GA30984@dhcp-26-207.brq.redhat.com> <20130905150442.GA24148@htj.dyndns.org> <20130905154041.GD30984@dhcp-26-207.brq.redhat.com> <20130905154436.GC24148@htj.dyndns.org> <20130905185440.GA13175@dhcp-26-207.brq.redhat.com> <20130905200608.GA3846@htj.dyndns.org> <20130906160621.GF22763@mtj.dyndns.org> <20130906233205.GF12956@google.com> <20130909152044.GA24962@dhcp-26-207.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20130909152044.GA24962@dhcp-26-207.brq.redhat.com> Sender: linux-pci-owner@vger.kernel.org To: Alexander Gordeev Cc: Bjorn Helgaas , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , "linux-pci@vger.kernel.org" , "linux-ide@vger.kernel.org" , Ingo Molnar , Joerg Roedel , Jan Beulich List-Id: linux-ide@vger.kernel.org Hello, On Mon, Sep 09, 2013 at 05:20:44PM +0200, Alexander Gordeev wrote: > The series is what it seems a direction to take. It can definitely use better descriptions explaining why this is happening but the general direction seems good to me. > Looks like we need PPC folks to agree on the quota check update > for pSeries (yes, they do bail out with a positive return value > from arch_msi_check_device()): > > quota = msi_quota_for_device(pdev, nvec); > > if (quota && quota < nvec) > return quota; I think it should return -ENOSPC. Thanks. -- tejun