From: Tejun Heo <tj@kernel.org>
To: Levente Kurusa <levex@linux.com>
Cc: linux-ide@vger.kernel.org, Kay Sievers <kay@vrfy.org>
Subject: Re: [PATCH] ata_piix: minor typo fixes and threading fix
Date: Thu, 26 Sep 2013 10:09:30 -0400 [thread overview]
Message-ID: <20130926140930.GA3482@htj.dyndns.org> (raw)
In-Reply-To: <CAAsK9AF_sJFcNTkCAR1vE5O80bJ0OoUL2AykqOoUvZt=5AYnxQ@mail.gmail.com>
(cc'ing Kay)
On Wed, Sep 25, 2013 at 04:40:30PM +0200, Levente Kurusa wrote:
> I am getting the following output:
> [ 2.236379] ata_piix 0000:00:1f.2: MAP [
> [ 2.236492] P0 P2 -- -- ]
> Instead of the expected:
> [ 2.236379] ata_piix 0000:00:1f.2: MAP [ P0 P2 -- -- ]
>
> This might be a minor problem, but I think it is better the second way.
> Of course, now that I better understand the code, I see that my fix to this,
> is not the best. I will make a new patch, if you think this should be fixed.
Hmmm... so, you're saying pr_cont() is misbehaving after dev_info()?
If so, we don't want to paper over that from a low level driver like
ata_piix. Let's find out what's going on with pr_cont().
Kay, Levente is seeing the above output from
drivers/ata/ata_piix.c::piix_init_sata_map(). Any ideas?
Thanks.
--
tejun
next prev parent reply other threads:[~2013-09-26 14:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-22 13:53 [PATCH] ata_piix: minor typo fixes and threading fix Levente Kurusa
2013-09-22 14:44 ` Sergei Shtylyov
2013-09-22 15:05 ` Levente Kurusa
2013-09-22 15:10 ` Sergei Shtylyov
2013-09-22 15:39 ` Tejun Heo
2013-09-22 15:46 ` Levente Kurusa
2013-09-22 16:05 ` Tejun Heo
2013-09-25 14:40 ` Levente Kurusa
2013-09-26 14:09 ` Tejun Heo [this message]
2013-09-26 17:14 ` Levente Kurusa
2013-09-26 17:57 ` Kay Sievers
2013-09-27 13:28 ` Tejun Heo
2013-09-27 13:29 ` Levente Kurusa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130926140930.GA3482@htj.dyndns.org \
--to=tj@kernel.org \
--cc=kay@vrfy.org \
--cc=levex@linux.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).