From: Tejun Heo <tj@kernel.org>
To: Kay Sievers <kay@vrfy.org>
Cc: Levente Kurusa <levex@linux.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata_piix: minor typo fixes and threading fix
Date: Fri, 27 Sep 2013 09:28:12 -0400 [thread overview]
Message-ID: <20130927132812.GB3205@htj.dyndns.org> (raw)
In-Reply-To: <CAPXgP13UZYEgdm6er8HrsoCiajwAXEzg_jn4Q7OgY2zDMGv-9g@mail.gmail.com>
Hello,
On Thu, Sep 26, 2013 at 07:57:35PM +0200, Kay Sievers wrote:
> > Kay, Levente is seeing the above output from
> > drivers/ata/ata_piix.c::piix_init_sata_map(). Any ideas?
>
> Yes, the dev_printk() versions are "atomic lines", cannot be
> concatenated with other invocations of printk() like the normal
> printks can. The reason is that the dev_* versions carry structured
> data to userspace, and there, the logs are indexed by device.
>
> We don't want to allow the convenient but very racy and
> non-thread-safe concatenation lines for dev_* versions, they might
> pick up unrelated text fragments from other threads into the logged
> text line; userspace (non-human tools) can not really cope with that.
>
> So, the printk should not use the dev_* version, or print all in one
> call, if a single line is expected.
I see. Levente, can you please go ahead and update the patch?
Thanks.
--
tejun
next prev parent reply other threads:[~2013-09-27 13:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-22 13:53 [PATCH] ata_piix: minor typo fixes and threading fix Levente Kurusa
2013-09-22 14:44 ` Sergei Shtylyov
2013-09-22 15:05 ` Levente Kurusa
2013-09-22 15:10 ` Sergei Shtylyov
2013-09-22 15:39 ` Tejun Heo
2013-09-22 15:46 ` Levente Kurusa
2013-09-22 16:05 ` Tejun Heo
2013-09-25 14:40 ` Levente Kurusa
2013-09-26 14:09 ` Tejun Heo
2013-09-26 17:14 ` Levente Kurusa
2013-09-26 17:57 ` Kay Sievers
2013-09-27 13:28 ` Tejun Heo [this message]
2013-09-27 13:29 ` Levente Kurusa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130927132812.GB3205@htj.dyndns.org \
--to=tj@kernel.org \
--cc=kay@vrfy.org \
--cc=levex@linux.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).