From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Gordeev Subject: Re: [PATCH RFC 06/77] PCI/MSI: Factor out pci_get_msi_cap() interface Date: Fri, 4 Oct 2013 07:13:24 +0200 Message-ID: <20131004051322.GA3577@dhcp-26-207.brq.redhat.com> References: <9c282c4ab92731c719d161d2db6fc54ce33891d9.1380703262.git.agordeev@redhat.com> <1380837174.3419.21.camel@bwh-desktop.uk.level5networks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1380837174.3419.21.camel@bwh-desktop.uk.level5networks.com> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Ben Hutchings Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas , Ralf Baechle , Michael Ellerman , Benjamin Herrenschmidt , Martin Schwidefsky , Ingo Molnar , Tejun Heo , Dan Williams , Andy King , Jon Mason , Matt Porter , linux-pci@vger.kernel.org, linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org, linux390@de.ibm.com, linux-s390@vger.kernel.org, x86@kernel.org, linux-ide@vger.kernel.org, iss_storagedev@hp.com, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net, linux-dr List-Id: linux-ide@vger.kernel.org On Thu, Oct 03, 2013 at 10:52:54PM +0100, Ben Hutchings wrote: > On Wed, 2013-10-02 at 12:48 +0200, Alexander Gordeev wrote: > > #ifndef CONFIG_PCI_MSI > > +static inline int pci_get_msi_cap(struct pci_dev *dev) > > +{ > > + return -1; > [...] > > Shouldn't this also return -EINVAL? Yep, all inliners here are better to return -EINVAL. Will do unless someone speaks out against. > Ben. -- Regards, Alexander Gordeev agordeev@redhat.com