* [PATCH V2 1/2] ahci: use dev_info() instead of printk()
@ 2013-10-05 0:15 Jingoo Han
2013-10-05 0:15 ` [PATCH V2 2/2] ahci_platform: " Jingoo Han
0 siblings, 1 reply; 4+ messages in thread
From: Jingoo Han @ 2013-10-05 0:15 UTC (permalink / raw)
To: 'Tejun Heo'; +Cc: linux-ide, 'Jingoo Han'
Change "raw" printk() call to dev_info() to provide a better
message to userspace so it can properly identify the device
and not just have to guess.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
Tested on Exynos5440.
drivers/ata/ahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 9d715ae..8e28f92 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1343,7 +1343,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss)
host->flags |= ATA_HOST_PARALLEL_SCAN;
else
- printk(KERN_INFO "ahci: SSS flag set, parallel bus scan disabled\n");
+ dev_info(&pdev->dev, "SSS flag set, parallel bus scan disabled\n");
if (pi.flags & ATA_FLAG_EM)
ahci_reset_em(host);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH V2 2/2] ahci_platform: use dev_info() instead of printk()
2013-10-05 0:15 [PATCH V2 1/2] ahci: use dev_info() instead of printk() Jingoo Han
@ 2013-10-05 0:15 ` Jingoo Han
2013-10-07 19:13 ` 'Tejun Heo'
0 siblings, 1 reply; 4+ messages in thread
From: Jingoo Han @ 2013-10-05 0:15 UTC (permalink / raw)
To: 'Tejun Heo'; +Cc: linux-ide, 'Jingoo Han'
Change "raw" printk() call to dev_info() to provide a better
message to userspace so it can properly identify the device
and not just have to guess.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
Tested on Exynos5440.
drivers/ata/ahci_platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c
index 2daaee0..7d3b853 100644
--- a/drivers/ata/ahci_platform.c
+++ b/drivers/ata/ahci_platform.c
@@ -184,7 +184,7 @@ static int ahci_probe(struct platform_device *pdev)
if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss)
host->flags |= ATA_HOST_PARALLEL_SCAN;
else
- printk(KERN_INFO "ahci: SSS flag set, parallel bus scan disabled\n");
+ dev_info(dev, "SSS flag set, parallel bus scan disabled\n");
if (pi.flags & ATA_FLAG_EM)
ahci_reset_em(host);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH V2 2/2] ahci_platform: use dev_info() instead of printk()
2013-10-05 0:15 ` [PATCH V2 2/2] ahci_platform: " Jingoo Han
@ 2013-10-07 19:13 ` 'Tejun Heo'
2013-10-07 19:25 ` 'Tejun Heo'
0 siblings, 1 reply; 4+ messages in thread
From: 'Tejun Heo' @ 2013-10-07 19:13 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-ide
On Sat, Oct 05, 2013 at 09:15:59AM +0900, Jingoo Han wrote:
> Change "raw" printk() call to dev_info() to provide a better
> message to userspace so it can properly identify the device
> and not just have to guess.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied to libata/for-3.13.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2 2/2] ahci_platform: use dev_info() instead of printk()
2013-10-07 19:13 ` 'Tejun Heo'
@ 2013-10-07 19:25 ` 'Tejun Heo'
0 siblings, 0 replies; 4+ messages in thread
From: 'Tejun Heo' @ 2013-10-07 19:25 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-ide
On Mon, Oct 07, 2013 at 03:13:10PM -0400, 'Tejun Heo' wrote:
> On Sat, Oct 05, 2013 at 09:15:59AM +0900, Jingoo Han wrote:
> > Change "raw" printk() call to dev_info() to provide a better
> > message to userspace so it can properly identify the device
> > and not just have to guess.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>
> Applied to libata/for-3.13.
Strike that. Applied to libata/for-3.12-fixes.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-07 19:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-05 0:15 [PATCH V2 1/2] ahci: use dev_info() instead of printk() Jingoo Han
2013-10-05 0:15 ` [PATCH V2 2/2] ahci_platform: " Jingoo Han
2013-10-07 19:13 ` 'Tejun Heo'
2013-10-07 19:25 ` 'Tejun Heo'
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).