From: Tejun Heo <tj@kernel.org>
To: xiangliang yu <yxlraid@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset
Date: Tue, 15 Oct 2013 08:50:31 -0400 [thread overview]
Message-ID: <20131015125031.GC3141@htj.dyndns.org> (raw)
In-Reply-To: <CAP0P+NWw2goofPtk5v8qKqAkhGwVJ7Bwn+Pj6meNhyK3KE2CAQ@mail.gmail.com>
Hello,
On Tue, Oct 15, 2013 at 11:40:27AM +0800, xiangliang yu wrote:
> @@ -1278,6 +1280,11 @@ int ahci_do_softreset(struct ata_link *link,
> unsigned int *class,
> if (rc && rc != -EOPNOTSUPP)
> ata_link_warn(link, "failed to reset engine (errno=%d)\n", rc);
>
Please add a comment here.
> + if (!ata_is_host_link(link) && pp->fbs_enabled) {
> + ahci_disable_fbs(ap);
> + fbs_flag = true;
> + }
White space damaged?
> +
> ata_tf_init(link->device, &tf);
>
> /* issue the first D2H Register FIS */
> @@ -1318,6 +1325,9 @@ int ahci_do_softreset(struct ata_link *link,
> unsigned int *class,
> } else
> *class = ahci_dev_classify(ap);
>
> + if (fbs_flag)
> + ahci_enable_fbs(ap);
> +
Thanks.
--
tejun
next prev parent reply other threads:[~2013-10-15 12:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-28 11:13 [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset Xiangliang Yu
2013-09-28 11:49 ` Tejun Heo
2013-09-28 13:04 ` xiangliang yu
2013-09-28 13:10 ` Tejun Heo
2013-10-12 6:56 ` xiangliang yu
2013-10-13 19:57 ` Tejun Heo
2013-10-14 1:48 ` xiangliang yu
2013-10-15 3:40 ` xiangliang yu
2013-10-15 12:50 ` Tejun Heo [this message]
2013-09-28 15:23 ` Sergei Shtylyov
[not found] <CAP0P+NUQSByVNquY-zP3S-6GKhSvQXgq_4dDCTd2R8FM=YC_Gg@mail.gmail.com>
2013-10-27 11:57 ` Tejun Heo
2013-10-28 1:48 ` xiangliang yu
2013-11-14 0:26 ` xiangliang yu
2013-11-14 5:25 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131015125031.GC3141@htj.dyndns.org \
--to=tj@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yxlraid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).