From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] drivers: ata: Mark the function ahci_init_interrupts() as static in ahci.c
Date: Sat, 14 Dec 2013 12:47:13 -0800 [thread overview]
Message-ID: <20131214204712.GM17601@leaf> (raw)
In-Reply-To: <81391ee13d565f1db31247dfda803cd7123bb8a9.1387029964.git.rashika.kheria@gmail.com>
On Sat, Dec 14, 2013 at 07:38:08PM +0530, Rashika Kheria wrote:
> This patch marks the function ahci_init_interrupts() as static in ahci.c
> because it is not used outside this file.
>
> Thus, it also eliminates the following warning in ahci.c:
> drivers/ata/ahci.c:1099:5: warning: no previous prototype for ‘ahci_init_interrupts’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/ata/ahci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 14f1e95..4ab1d41 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1097,7 +1097,7 @@ static inline void ahci_gtf_filter_workaround(struct ata_host *host)
> {}
> #endif
>
> -int ahci_init_interrupts(struct pci_dev *pdev, struct ahci_host_priv *hpriv)
> +static int ahci_init_interrupts(struct pci_dev *pdev, struct ahci_host_priv *hpriv)
> {
> int rc;
> unsigned int maxvec;
> --
> 1.7.9.5
>
prev parent reply other threads:[~2013-12-14 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 14:08 [PATCH 1/2] drivers: ata: Mark the function ahci_init_interrupts() as static in ahci.c Rashika Kheria
2013-12-14 14:10 ` [PATCH 2/2] drivers: ata: Mark the function as static in libahci.c Rashika Kheria
2013-12-14 20:47 ` Josh Triplett
2013-12-14 21:23 ` Tejun Heo
2013-12-14 20:47 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131214204712.GM17601@leaf \
--to=josh@joshtriplett.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).