From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Triplett Subject: Re: [PATCH 2/2] drivers: ata: Mark the function as static in libahci.c Date: Sat, 14 Dec 2013 12:47:32 -0800 Message-ID: <20131214204732.GN17601@leaf> References: <81391ee13d565f1db31247dfda803cd7123bb8a9.1387029964.git.rashika.kheria@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from relay4-d.mail.gandi.net ([217.70.183.196]:46022 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753862Ab3LNUrj convert rfc822-to-8bit (ORCPT ); Sat, 14 Dec 2013 15:47:39 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, Tejun Heo , linux-ide@vger.kernel.org On Sat, Dec 14, 2013 at 07:40:21PM +0530, Rashika Kheria wrote: > This patch marks the function ahci_port_intr() and > ahci_hw_port_interrupt() as static in libahci.c because they are not > used outside this file. >=20 > Thus, it also eliminates the following warnings in libahci.c: > drivers/ata/libahci.c:1767:6: warning: no previous prototype for =E2=80= =98ahci_port_intr=E2=80=99 [-Wmissing-prototypes] > drivers/ata/libahci.c:1800:6: warning: no previous prototype for =E2=80= =98ahci_hw_port_interrupt=E2=80=99 [-Wmissing-prototypes] >=20 > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/ata/libahci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c > index c482f8c..36605ab 100644 > --- a/drivers/ata/libahci.c > +++ b/drivers/ata/libahci.c > @@ -1764,7 +1764,7 @@ static void ahci_handle_port_interrupt(struct a= ta_port *ap, > } > } > =20 > -void ahci_port_intr(struct ata_port *ap) > +static void ahci_port_intr(struct ata_port *ap) > { > void __iomem *port_mmio =3D ahci_port_base(ap); > u32 status; > @@ -1797,7 +1797,7 @@ irqreturn_t ahci_thread_fn(int irq, void *dev_i= nstance) > } > EXPORT_SYMBOL_GPL(ahci_thread_fn); > =20 > -void ahci_hw_port_interrupt(struct ata_port *ap) > +static void ahci_hw_port_interrupt(struct ata_port *ap) > { > void __iomem *port_mmio =3D ahci_port_base(ap); > struct ahci_port_priv *pp =3D ap->private_data; > --=20 > 1.7.9.5 >=20