From: Josh Triplett <josh@joshtriplett.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Rashika Kheria <rashika.kheria@gmail.com>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] drivers: ide: Include appropriate header file in ide-cd_verbose.c
Date: Tue, 17 Dec 2013 08:44:03 -0800 [thread overview]
Message-ID: <20131217164403.GD1062@leaf> (raw)
In-Reply-To: <20131217111920.GA30592@pd.tnic>
On Tue, Dec 17, 2013 at 12:19:21PM +0100, Borislav Petkov wrote:
> On Tue, Dec 17, 2013 at 04:38:16PM +0530, Rashika Kheria wrote:
> > Include appropriate header file ide-cd.h in ide-cd_verbose.c because
> > function ide_cd_log_error() has its prototype declaration in ide-cd.h.
> > Also, include linux/ide.h because it contains certain declarations
> > necessary for including ide-cd.h.
> >
> > This eliminates the following warnings in ide-cd_verbose.c:
> > drivers/ide/ide-cd_verbose.c:251:6: warning: no previous prototype for ‘ide_cd_log_error’ [-Wmissing-prototypes]
>
> drivers/ide/ is open only to fixes for serious, real bugs - nothing
> else. I wouldn't waste my time with it if I were you.
A quick check of "git log drivers/ide/" turns up a pile of fixes and
cleanups; for instance:
c2f7d1e ide: pmac: remove unnecessary pci_set_drvdata()
a6fd6063 ide: cs5536: use module_pci_driver()
58e48be ide: pmac: Remove casting the return value which is a void pointer
64110c1 ide: sgiioc4: Staticize ioc4_ide_attach_one()
70ddce8 ide: palm_bk3710: add missing __iomem annotation
The two proposed patches here are extremely low risk, don't actually
change the compiled code in any way like some of those did, and fix real
compiler warnings.
- Josh Triplett
next prev parent reply other threads:[~2013-12-17 16:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 11:08 [PATCH 1/2] drivers: ide: Include appropriate header file in ide-cd_verbose.c Rashika Kheria
2013-12-17 11:11 ` [PATCH 2/2] drivers: ide: Include appropriate header file in ide-pio-blacklist.c Rashika Kheria
2013-12-17 16:37 ` Josh Triplett
2014-01-29 7:37 ` David Miller
2013-12-17 11:19 ` [PATCH 1/2] drivers: ide: Include appropriate header file in ide-cd_verbose.c Borislav Petkov
2013-12-17 16:44 ` Josh Triplett [this message]
2013-12-17 17:54 ` Borislav Petkov
2013-12-17 19:42 ` Sergei Shtylyov
2013-12-17 19:06 ` Borislav Petkov
2013-12-18 13:23 ` Bartlomiej Zolnierkiewicz
2013-12-18 13:33 ` Borislav Petkov
2013-12-18 18:35 ` Sergei Shtylyov
2013-12-17 16:37 ` Josh Triplett
2013-12-17 18:11 ` Sergei Shtylyov
2014-01-29 7:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217164403.GD1062@leaf \
--to=josh@joshtriplett.org \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).