From: Arnd Bergmann <arnd@arndb.de>
To: Mohit Kumar <mohit.kumar@st.com>
Cc: Pratyush Anand <pratyush.anand@st.com>, Tejun Heo <tj@kernel.org>,
spear-devel@list.st.com, linux-ide@vger.kernel.org,
Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH V3 5/8] ata: ahci platform: Add phy hooks to make it more generic
Date: Thu, 30 Jan 2014 14:06:14 +0100 [thread overview]
Message-ID: <201401301406.14444.arnd@arndb.de> (raw)
In-Reply-To: <f82b7b246b8bedb153de5d360638ce79f13d61f0.1391077731.git.mohit.kumar@st.com>
On Thursday 30 January 2014, Mohit Kumar wrote:
> From: Pratyush Anand <pratyush.anand@st.com>
>
> Few platform does only phy specific work in platform callbacks. It is
> better to use standard phy callbacks for such platform in stead of
> platform callbacks.
>
> This patch does not break any platform callbacks. It adds phy plugins
> on top of that.
>
> It has been assumed that no platform will need both phy plugins as well
> as platform callbacks.
>
> Signed-off-by: Pratyush Anand <pratyush.anand@st.com>
> Cc: Mohit Kumar <mohit.kumar@st.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: spear-devel@list.st.com
> Cc: linux-ide@vger.kernel.org
This patch looks good to me, but as I mentioned, there has
been some related work recently. Please see the patch from
Roger Quadros posted at http://lkml.org/lkml/2014/1/8/142
One of the two should be enough.
Arnd
next prev parent reply other threads:[~2014-01-30 13:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 10:48 [PATCH V3 0/8] PCI:Add SPEAr13xx PCie support Mohit Kumar
2014-01-30 10:48 ` [PATCH V3 5/8] ata: ahci platform: Add phy hooks to make it more generic Mohit Kumar
2014-01-30 13:06 ` Arnd Bergmann [this message]
2014-01-31 3:52 ` Pratyush Anand
[not found] ` <cover.1391077731.git.mohit.kumar-qxv4g6HH51o@public.gmane.org>
2014-01-30 10:48 ` [PATCH V3 6/8] SPEAr13xx: Fixup: Move SPEAr1340 SATA platform code to phy driver Mohit Kumar
2014-01-30 13:21 ` Arnd Bergmann
2014-01-31 4:12 ` Pratyush Anand
2014-01-31 15:27 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401301406.14444.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-ide@vger.kernel.org \
--cc=mohit.kumar@st.com \
--cc=pratyush.anand@st.com \
--cc=rogerq@ti.com \
--cc=spear-devel@list.st.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).