From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: tj@kernel.org, kishon@ti.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH 3/3] ata: sata_mv: Fix probe failures with optional phys
Date: Sat, 1 Feb 2014 12:36:05 -0300 [thread overview]
Message-ID: <20140201153604.GA20710@localhost> (raw)
In-Reply-To: <20140201145659.GF26003@lunn.ch>
On Sat, Feb 01, 2014 at 03:56:59PM +0100, Andrew Lunn wrote:
> > IMHO, this new series look much better. However, I still think the above code
> > is highly confusing (took me some time to see why you don't print the warning
> > on PROBE_DEFER, but do the goto in all cases).
> >
> > Would it be too much to ask to add some comments to it? Your previous
> > explanation about why we need to fail on EPROBE_DEFER, to allow the phy
> > driver to load, was great. Adding some of that here would be nice.
>
> Anybody writing device drivers should know about EPROBE_DEFER. If
> they don't they are writing broken drivers. So putting in a comment
> here would be just pointing out the obvious.
>
Maybe you're right. It wasn't obvious to me, though.
> What i can however do is add a comment that devm_phy_get_optional()
> returns a valid phy if there is no error. Might that help with the
> confusion?
>
Well, In don't think devm_phy_get_optional() brings any confusion.
The name itself is pretty self-explanatory, and in that case you can always
go look at the function implementation and documentation.
So, I'd say no.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-02-01 15:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0140131114857.GC26148@htj.dyndns.org>
2014-02-01 14:15 ` [PATCH 1/3] drivers: phy: Make NULL a valid phy reference Andrew Lunn
2014-02-01 14:15 ` [PATCH 2/3] drivers: phy: Add support for optional phys Andrew Lunn
2014-02-03 5:51 ` Kishon Vijay Abraham I
2014-02-03 9:36 ` Andrew Lunn
2014-02-03 10:19 ` Kishon Vijay Abraham I
2014-02-03 18:00 ` [patch v2 1/3] drivers: phy: Make NULL a valid phy reference Andrew Lunn
2014-02-03 18:00 ` [patch v2 2/3] drivers: phy: Add support for optional phys Andrew Lunn
2014-02-03 18:00 ` [patch v2 3/3] ata: sata_mv: Fix probe failures with " Andrew Lunn
2014-02-03 18:02 ` Tejun Heo
2014-02-03 19:04 ` Sergei Shtylyov
2014-02-03 18:17 ` [patch v3 " Andrew Lunn
2014-02-03 19:21 ` Sergei Shtylyov
2014-02-03 19:06 ` [patch v2 1/3] drivers: phy: Make NULL a valid phy reference Sergei Shtylyov
2014-02-03 18:13 ` Andrew Lunn
2014-02-03 19:17 ` Sergei Shtylyov
2014-02-03 21:15 ` Gregory CLEMENT
2014-02-01 14:15 ` [PATCH 3/3] ata: sata_mv: Fix probe failures with optional phys Andrew Lunn
2014-02-01 14:44 ` Ezequiel Garcia
2014-02-01 14:56 ` Andrew Lunn
2014-02-01 15:36 ` Ezequiel Garcia [this message]
2014-02-03 16:03 ` Tejun Heo
2014-02-03 16:20 ` Andrew Lunn
2014-02-03 16:21 ` Tejun Heo
2014-02-03 16:21 ` Gregory CLEMENT
2014-02-03 17:17 ` Gregory CLEMENT
2014-02-03 17:23 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140201153604.GA20710@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=kishon@ti.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).