Re: [PATCH 3/3] ata: sata_mv: Fix probe failures with optional phys

[Andrew Lunn <andrew@lunn.ch>]

> I have just tested it on both Armada 370 and Armada XP and it failed
> at the end of the mv_platform_probe function while trying to do a
> clk_put on the clocks on the second port.

That is odd

drivers/clk/clkdev.c_
void clk_put(struct clk *clk)
{
	__clk_put(clk);
}

and arch/arm/include/asm/clkdev.h

#define __clk_put(clk)  do { } while (0)

How can that cause a crash.

However, PC is at __clk_put+0x1c/0x8c

0x8c is a lot of instructions for what should be NOP.

Could you please take a look at this.

> Indeed the devm_phy_optional_get failed on the 1st port, so the clock
> of the second port was not allocated. What I don't get is why the
> IS_ERR check don't work here.

Remember that NULL is not an error. I'm assuming it is somehow
dereferencing NULL.

	 Andrew