From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Williams Subject: [PATCH v5 2/3] libata: async resume Date: Wed, 05 Mar 2014 12:17:35 -0800 Message-ID: <20140305201735.20088.22124.stgit@viggo.jf.intel.com> References: <20140305201443.20088.85361.stgit@viggo.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com ([134.134.136.20]:11271 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754222AbaCEUSG (ORCPT ); Wed, 5 Mar 2014 15:18:06 -0500 In-Reply-To: <20140305201443.20088.85361.stgit@viggo.jf.intel.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: tj@kernel.org, JBottomley@Parallels.com Cc: Len Brown , linux-scsi@vger.kernel.org, Phillip Susi , linux-ide@vger.kernel.org, Alan Stern , Todd Brandt From: Todd Brandt Improve overall system resume time by making libata link recovery actions asynchronous relative to other resume events. Link resume operations are performed using the scsi_eh thread, so commands, particularly the sd resume start/stop command, will be held off until the device exits error handling. Libata already flushes eh with ata_port_wait_eh() in the port teardown paths, so there are no concerns with async operation colliding with the end-of-life of the ata_port object. Also, libata-core is already careful to flush in-flight pm operations before another round of pm starts on the given ata_port. Reference: https://01.org/suspendresume/blogs/tebrandt/2013/hard-disk-resume-optimization-simpler-approach Cc: Len Brown Cc: Phillip Susi Cc: Alan Stern Signed-off-by: Todd Brandt [djbw: rebase on cleanup patch, changelog wordsmithing] Signed-off-by: Dan Williams --- drivers/ata/libata-core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 0f47436c714c..7719ec7d9df9 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -5444,7 +5444,7 @@ static int ata_port_resume(struct device *dev) { int rc; - rc = ata_port_resume_sync(to_ata_port(dev), PMSG_RESUME); + rc = queue_ata_port_resume(to_ata_port(dev), PMSG_RESUME); if (!rc) { pm_runtime_disable(dev); pm_runtime_set_active(dev);