From: Dan Williams <dan.j.williams@intel.com>
To: tj@kernel.org, JBottomley@Parallels.com
Cc: Len Brown <len.brown@intel.com>,
linux-scsi@vger.kernel.org, Phillip Susi <psusi@ubuntu.com>,
linux-ide@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
Todd Brandt <todd.e.brandt@linux.intel.com>,
Todd Brandt <todd.e.brandt@intel.com>
Subject: [PATCH v6 0/3] Accelerate Storage Resume (2x or more)
Date: Fri, 14 Mar 2014 13:52:43 -0700 [thread overview]
Message-ID: <20140314205204.1269.44402.stgit@viggo.jf.intel.com> (raw)
Changes since v5:
* Per Tejun, fixed up the naming of the ata_port helper routines
* Cleaned up the return value of ata_port_pm helper routines to be 'void'
* Per Tejun, added a check of whether async scanning is disabled to gate
whether async resume will be performed out of caution for systems that
do not handle staggered spin-up outside of the kernel. Clarified this
in the changelog and added commentary in the code.
===
It is not everyday that a kernel operation gets > 2x faster! Great find
by Todd and his AnalyzeSuspend tool [1].
Todd is on vacation so I am taking care of these patches to make sure
they get in the queue for 3.15.
The significant changes from Todd's last submission [2]:
1/ Split out the pure cleanup into its own patch, and expand it to clean
up libsas as well
2/ Move the entirety of scsi_device resume to an async context. As
written, v4 of the patchset overlapped the scsi-start-stop command
with the scsi_device_resume(). Now in v5 the queue restart is
properly ordered with the completion of the scsi-start-stop command.
Resume completion time as reported by:
"echo devices > /sys/power/pm_test && echo mem > /sys/power/state"
BEFORE: PM: resume of devices complete after 2271.097 msecs
AFTER: PM: resume of devices complete after 1057.404 msecs
On a system with two SSDs attached via AHCI.
[1]: Todd's testing showing up to 12x resume latency improvement in some
cases:
https://01.org/suspendresume/blogs/tebrandt/2013/hard-disk-resume-optimization-simpler-approach
[2]: Todd's v4 patchset:
[PATCH v4 0/2] http://marc.info/?l=linux-ide&m=138984698103487&w=2
[PATCH v4 1/2] http://marc.info/?l=linux-ide&m=138984713203515&w=2
[PATCH v4 2/2] http://marc.info/?l=linux-ide&m=138984722003539&w=2
---
Dan Williams (2):
libata, libsas: kill pm_result and related cleanup
scsi: async sd resume
Todd Brandt (1):
libata: async resume
drivers/ata/libata-core.c | 135 ++++++++++++++++++-----------------------
drivers/ata/libata-eh.c | 13 +---
drivers/scsi/Kconfig | 3 +
drivers/scsi/libsas/sas_ata.c | 35 ++---------
drivers/scsi/scsi.c | 3 +
drivers/scsi/scsi_pm.c | 128 ++++++++++++++++++++++++++++++---------
drivers/scsi/scsi_priv.h | 2 +
drivers/scsi/scsi_scan.c | 2 -
drivers/scsi/sd.c | 1
include/linux/libata.h | 11 +--
include/scsi/libsas.h | 1
11 files changed, 180 insertions(+), 154 deletions(-)
next reply other threads:[~2014-03-14 20:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 20:52 Dan Williams [this message]
2014-03-14 20:52 ` [PATCH v6 1/3] libata, libsas: kill pm_result and related cleanup Dan Williams
2014-03-18 16:03 ` Tejun Heo
2014-03-18 16:48 ` Dan Williams
2014-03-18 20:18 ` Tejun Heo
2014-03-14 20:52 ` [PATCH v6 2/3] libata: async resume Dan Williams
2014-03-14 20:52 ` [PATCH v6 3/3] scsi: async sd resume Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140314205204.1269.44402.stgit@viggo.jf.intel.com \
--to=dan.j.williams@intel.com \
--cc=JBottomley@Parallels.com \
--cc=len.brown@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=psusi@ubuntu.com \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
--cc=todd.e.brandt@intel.com \
--cc=todd.e.brandt@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox