From: Tejun Heo <tj@kernel.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-ide@vger.kernel.org, Chris Samuel <chris@csamuel.org>,
Marc MERLIN <marc@merlins.org>
Subject: Re: [PATCH 1/2] libata: Expose trim capability in sysfs
Date: Wed, 16 Apr 2014 16:16:13 -0400 [thread overview]
Message-ID: <20140416201613.GI22569@htj.dyndns.org> (raw)
In-Reply-To: <1396399357-28388-1-git-send-email-martin.petersen@oracle.com>
Hello,
On Tue, Apr 01, 2014 at 08:42:36PM -0400, Martin K. Petersen wrote:
> +static ssize_t
> +show_ata_dev_trim(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct ata_device *ata_dev = transport_class_to_dev(dev);
> + unsigned int mode;
Let's please just do
const char *mode = "unsupported";
if (ata_id_has_trim(ata_dev->id)) {
if (ata_fpdma_dsm_supported(ata_dev))
mode = "queued";
else
mode = "unqueued";
}
return sprintf(buf, "%s\n", mode);
Thanks.
--
tejun
prev parent reply other threads:[~2014-04-16 20:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 0:42 [PATCH 1/2] libata: Expose trim capability in sysfs Martin K. Petersen
2014-04-02 0:42 ` [PATCH 2/2] libata: Update queued trim blacklist for M5x0 drives Martin K. Petersen
2014-04-02 17:11 ` Tejun Heo
2014-04-02 17:09 ` [PATCH 1/2] libata: Expose trim capability in sysfs Tejun Heo
2014-04-02 17:26 ` Martin K. Petersen
2014-04-04 17:29 ` Marc MERLIN
2014-04-04 21:49 ` Chris Samuel
2014-04-05 8:12 ` Chris Samuel
2014-04-07 19:52 ` Martin K. Petersen
2014-04-06 4:03 ` Marc MERLIN
[not found] ` <1403024.0HLhjfholh@quad>
2014-04-06 6:19 ` Marc MERLIN
2014-04-16 20:16 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416201613.GI22569@htj.dyndns.org \
--to=tj@kernel.org \
--cc=chris@csamuel.org \
--cc=linux-ide@vger.kernel.org \
--cc=marc@merlins.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).