From: Tejun Heo <tj@kernel.org>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: David Milburn <dmilburn@redhat.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libahci: ahci interrupt check for disabled port since private_data may be NULL
Date: Thu, 17 Apr 2014 09:45:43 -0400 [thread overview]
Message-ID: <20140417134543.GD15326@htj.dyndns.org> (raw)
In-Reply-To: <20140417124436.GC2270@dhcp-26-207.brq.redhat.com>
On Thu, Apr 17, 2014 at 02:44:36PM +0200, Alexander Gordeev wrote:
> On Thu, Apr 17, 2014 at 09:29:42AM -0400, Tejun Heo wrote:
> > On Thu, Apr 17, 2014 at 10:29:35AM +0200, Alexander Gordeev wrote:
> > > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> > > index e45b18e..9f1169a 100644
> > > --- a/drivers/ata/ahci.c
> > > +++ b/drivers/ata/ahci.c
> > > @@ -1240,6 +1240,8 @@ int ahci_host_activate(struct ata_host *host, int irq, unsigned int n_msis)
> > > irq + i, ahci_hw_interrupt,
> > > ahci_thread_fn, IRQF_SHARED,
> > > pp->irq_desc, host->ports[i]);
> > > + else
> > > + disable_irq(irq + i);
> >
> > Hmmm? Request failed. Why would it require an explicit disable?
>
> if (pp)
> rc = devm_request_threaded_irq(..., irq + i, ...)
> else
> disable_irq(irq + i);
Ah, was looking at the old code. But again, we didn't even request
the irq, why would we disable it?
Thanks.
--
tejun
next prev parent reply other threads:[~2014-04-17 13:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 21:47 [PATCH] libahci: ahci interrupt check for disabled port since private_data may be NULL David Milburn
2014-04-15 16:33 ` Tejun Heo
2014-04-15 18:18 ` David Milburn
2014-04-15 18:20 ` Tejun Heo
2014-04-16 7:39 ` Alexander Gordeev
2014-04-16 15:19 ` Tejun Heo
2014-04-16 16:28 ` David Milburn
2014-04-16 18:51 ` Alexander Gordeev
2014-04-16 19:14 ` Tejun Heo
2014-04-17 8:29 ` Alexander Gordeev
2014-04-17 13:29 ` Tejun Heo
2014-04-17 12:44 ` Alexander Gordeev
2014-04-17 13:45 ` Tejun Heo [this message]
2014-04-17 13:07 ` Alexander Gordeev
2014-04-17 14:09 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140417134543.GD15326@htj.dyndns.org \
--to=tj@kernel.org \
--cc=agordeev@redhat.com \
--cc=dmilburn@redhat.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).