From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v4 1/7] phy: add a driver for the Berlin SATA PHY Date: Tue, 20 May 2014 15:49:42 +0200 Message-ID: <20140520134942.GC9873@lunn.ch> References: <1400576675-25265-1-git-send-email-antoine.tenart@free-electrons.com> <1400576675-25265-2-git-send-email-antoine.tenart@free-electrons.com> <1821771.zFvTDGF2Ae@amdc1032> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from vps0.lunn.ch ([178.209.37.122]:48679 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092AbaETNxE (ORCPT ); Tue, 20 May 2014 09:53:04 -0400 Content-Disposition: inline In-Reply-To: <1821771.zFvTDGF2Ae@amdc1032> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: Antoine =?iso-8859-1?Q?T=E9nart?= , thomas.petazzoni@free-electrons.com, zmxu@marvell.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, linux-ide@vger.kernel.org, alexandre.belloni@free-electrons.com, jszhang@marvell.com, tj@kernel.org, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com On Tue, May 20, 2014 at 02:34:20PM +0200, Bartlomiej Zolnierkiewicz wro= te: >=20 > Hi, >=20 > Few minor issues below.. >=20 > On Tuesday, May 20, 2014 11:04:29 AM Antoine T=E9nart wrote: > > The Berlin SoC has a two SATA ports. Add a PHY driver to handle the= m. > >=20 > > The mode selection can let us think this PHY can be configured to f= it > > other purposes. But there are reasons to think the SATA mode will b= e > > the only one usable: the PHY registers are only accessible indirect= ly > > through two registers in the SATA range, the PHY seems to be integr= ated > > and no information tells us the contrary. For these reasons, make t= he > > driver a SATA PHY driver. > >=20 > > Signed-off-by: Antoine T=E9nart > > --- > > drivers/phy/Kconfig | 5 + > > drivers/phy/Makefile | 1 + > > drivers/phy/phy-berlin-sata.c | 230 ++++++++++++++++++++++++++++++= ++++++++++++ > > 3 files changed, 236 insertions(+) > > create mode 100644 drivers/phy/phy-berlin-sata.c > >=20 > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > > index 4906c27fa3bd..b31b1986fda4 100644 > > --- a/drivers/phy/Kconfig > > +++ b/drivers/phy/Kconfig > > @@ -15,6 +15,11 @@ config GENERIC_PHY > > phy users can obtain reference to the PHY. All the users of thi= s > > framework should select this config. > > =20 > > +config PHY_BERLIN_SATA > > + bool >=20 > Is there any real reason why this cannot be tristate? What we have seen with SATA drivers and phys, is there is link time breakage if the SATA driver is built in and the phy is modular. Maybe this has been fixed now?=20 =20 Andrew