[PATCH 1/5] ata: ahci_imx: warn when disabling ahci link

[PATCH 1/5] ata: ahci_imx: warn when disabling ahci link

[Russell King]

When the AHCI link is disabled, it can't be re-enabled except by
resetting the entire SoC.  Rather than doing this silently print
some kernel messages to inform the user, along with how to avoid
this.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 drivers/ata/ahci_imx.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/ata/ahci_imx.c b/drivers/ata/ahci_imx.c
index 3a901520c62b..4eba1c5279ec 100644
--- a/drivers/ata/ahci_imx.c
+++ b/drivers/ata/ahci_imx.c
@@ -324,6 +324,10 @@ static void ahci_imx_error_handler(struct ata_port *ap)
 	writel(reg_val | IMX_P0PHYCR_TEST_PDDQ, mmio + IMX_P0PHYCR);
 	imx_sata_disable(hpriv);
 	imxpriv->no_device = true;
+
+	dev_info(ap->dev, "no device found, disabling link.\n");
+	dev_info(ap->dev, "pass " MODULE_PARAM_PREFIX
+		 ".hotplug=1 to enable hotplug\n");
 }
 
 static int ahci_imx_softreset(struct ata_link *link, unsigned int *class,
-- 
1.8.3.1

Re: [PATCH 1/5] ata: ahci_imx: warn when disabling ahci link

[Tejun Heo]

On Mon, Jun 23, 2014 at 12:59:08PM +0100, Russell King wrote:
> When the AHCI link is disabled, it can't be re-enabled except by
> resetting the entire SoC.  Rather than doing this silently print
> some kernel messages to inform the user, along with how to avoid
> this.
> 
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

Applied to libata/for-3.16-fixes w/ the printf format string put on a
single line.

Thanks.

-- 
tejun