From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
James Bottomely <jbottomley@parallels.com>
Subject: Re: [PATCH 4/4] sd: Handle ZBC drives correctly
Date: Mon, 21 Jul 2014 04:29:04 -0700 [thread overview]
Message-ID: <20140721112904.GB15455@infradead.org> (raw)
In-Reply-To: <1405931241-92015-5-git-send-email-hare@suse.de>
On Mon, Jul 21, 2014 at 10:27:21AM +0200, Hannes Reinecke wrote:
> ZBC drives are close to disk devices, so update sd.c to handle
> ZBC drives correctly.
While the other patches all look fine with me I strongly disagree with
this one. Devices reporting the ZBC device type must have sequential
required zones, so they are _not_ anywhere close to disk devices,
and writes to them will cause errors that we aren't evenable able to
handle yet.
If it makes some sort of experiment easier for you we can add a way to
force ZBC devices to use sd.c conditionally. Do you have a test device
that this works with?
next prev parent reply other threads:[~2014-07-21 11:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 8:27 [PATCHv2 0/4] Initial SMR drive support Hannes Reinecke
2014-07-21 8:27 ` [PATCH 1/4] libata: consolidate ata_dev_classify() Hannes Reinecke
2014-07-21 8:27 ` [PATCH 2/4] libata: Implement ATA_DEV_ZAC Hannes Reinecke
2014-07-21 8:27 ` [PATCH 3/4] libata-scsi: Update SATL for ZAC drives Hannes Reinecke
2014-07-21 8:27 ` [PATCH 4/4] sd: Handle ZBC drives correctly Hannes Reinecke
2014-07-21 11:29 ` Christoph Hellwig [this message]
2014-07-21 11:51 ` Hannes Reinecke
2014-07-21 15:01 ` Christoph Hellwig
2014-07-21 16:18 ` John Utz
2014-07-21 16:30 ` John Utz
2014-07-21 17:49 ` Hannes Reinecke
2014-07-22 16:19 ` Christoph Hellwig
2014-07-22 18:25 ` John Utz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140721112904.GB15455@infradead.org \
--to=hch@infradead.org \
--cc=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).