From: Tejun Heo <tj@kernel.org>
To: Arjun Sreedharan <arjun024@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: propagate return value of scc_wait_after_reset
Date: Sun, 17 Aug 2014 09:07:27 -0400 [thread overview]
Message-ID: <20140817130727.GA7679@mtj.dyndns.org> (raw)
In-Reply-To: <CAJFMrCEdrqWvktexp5nFooz1UdSE4yZ+F15NnaZ5E9p7_z_iqQ@mail.gmail.com>
On Sun, Aug 17, 2014 at 05:31:53PM +0530, Arjun Sreedharan wrote:
> Also now i feel @err_mask is better.
> I rest my case further. Thanks.
The thing is err_mask is used in libata to carry AC_ERR_* values not
0/-errno's, so it's confusing to use it for that. Can you please
refresh the patch w/ variable rename?
Thanks.
--
tejun
next prev parent reply other threads:[~2014-08-17 13:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53ef6157.qX8Csumbm2zNx/EI%fengguang.wu@intel.com>
2014-08-16 14:18 ` [PATCH] ata: propagate return value of scc_wait_after_reset Arjun Sreedharan
2014-08-17 11:10 ` Tejun Heo
2014-08-17 11:27 ` Tejun Heo
2014-08-17 12:01 ` Arjun Sreedharan
2014-08-17 13:07 ` Tejun Heo [this message]
2014-08-16 10:17 Arjun Sreedharan
2014-08-16 11:37 ` Tejun Heo
2014-08-16 12:04 ` Arjun Sreedharan
2014-08-16 12:21 ` Tejun Heo
2014-08-16 12:25 ` Arjun Sreedharan
2014-08-16 12:50 ` Arjun Sreedharan
2014-08-16 12:55 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140817130727.GA7679@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=arjun024@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).