From: Tejun Heo <tj@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: hdegoede@redhat.com, linux-ide@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] libahci_platform: Staticize ahci_platform_<en/dis>able_phys()
Date: Sun, 31 Aug 2014 00:01:58 -0400 [thread overview]
Message-ID: <20140831040158.GA5013@htj.dyndns.org> (raw)
In-Reply-To: <1409427549-1846-1-git-send-email-festevam@gmail.com>
On Sat, Aug 30, 2014 at 04:39:09PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> ahci_platform_enable_phys() and ahci_platform_disable_phys() are currently
> exported, but they are not used anywhere else other than libahci_platform.c.
>
> So make them static and do not export them to fix the following sparse
> warnings:
>
> drivers/ata/libahci_platform.c:52:5: warning: symbol 'ahci_platform_enable_phys' was not declared. Should it be static?
> drivers/ata/libahci_platform.c:88:6: warning: symbol 'ahci_platform_disable_phys' was not declared. Should it be static?
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied to libata/for-3.18. Thanks.
--
tejun
prev parent reply other threads:[~2014-08-31 4:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-30 19:39 [PATCH] libahci_platform: Staticize ahci_platform_<en/dis>able_phys() Fabio Estevam
2014-08-31 4:01 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140831040158.GA5013@htj.dyndns.org \
--to=tj@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).