From: Tejun Heo <tj@kernel.org>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com,
falcon@meizu.com, tiwai@suse.de, arjan@linux.intel.com,
linux-kernel@vger.kernel.org, oleg@redhat.com, hare@suse.com,
akpm@linux-foundation.org, penguin-kernel@i-love.sakura.ne.jp,
joseph.salisbury@canonical.com, bpoirier@suse.de,
santosh@chelsio.com, "Luis R. Rodriguez" <mcgrof@suse.com>,
linux-ide@vger.kernel.org,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
patrakov@gmail.com
Subject: Re: [RFC v2 6/6] pata_marvell: use async probe
Date: Fri, 5 Sep 2014 16:15:35 +0900 [thread overview]
Message-ID: <20140905071535.GA9323@mtj.dyndns.org> (raw)
In-Reply-To: <1409899047-13045-7-git-send-email-mcgrof@do-not-panic.com>
On Thu, Sep 04, 2014 at 11:37:27PM -0700, Luis R. Rodriguez wrote:
> diff --git a/drivers/ata/pata_marvell.c b/drivers/ata/pata_marvell.c
> index ae9feb1..6a543b9 100644
> --- a/drivers/ata/pata_marvell.c
> +++ b/drivers/ata/pata_marvell.c
> @@ -175,6 +175,7 @@ static struct pci_driver marvell_pci_driver = {
> .suspend = ata_pci_device_suspend,
> .resume = ata_pci_device_resume,
> #endif
> + .driver.async_probe = true,
You can't do this. There's nothing special about pata_marvell. Sure
there was a bug report which made long probe durations more common on
this driver on certain configurations but those long durations can
happen on *any* libata driver and singling out pata_marvell for async
probing is adding a different probing behavior basically arbitrarily.
I really can't see how this marking random drivers with async probing
would work, so one driver does synchronous probing while the
equivalent next one doesn't? That's crazy.
Thanks.
--
tejun
prev parent reply other threads:[~2014-09-05 7:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1409899047-13045-1-git-send-email-mcgrof@do-not-panic.com>
2014-09-05 6:37 ` [RFC v2 6/6] pata_marvell: use async probe Luis R. Rodriguez
2014-09-05 6:59 ` Alexander E. Patrakov
2014-09-05 7:15 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905071535.GA9323@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=bpoirier@suse.de \
--cc=dmitry.torokhov@gmail.com \
--cc=falcon@meizu.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=joseph.salisbury@canonical.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=oleg@redhat.com \
--cc=patrakov@gmail.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=santosh@chelsio.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).