From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 1/4] libata: consolidate ata_dev_classify() Date: Sat, 6 Sep 2014 21:52:27 +0900 Message-ID: <20140906125227.GA29401@mtj.dyndns.org> References: <1406706911-79510-1-git-send-email-hare@suse.de> <1406706911-79510-2-git-send-email-hare@suse.de> <20140905234241.GH15723@mtj.dyndns.org> <540AC41F.8020506@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <540AC41F.8020506@suse.de> Sender: linux-scsi-owner@vger.kernel.org To: Hannes Reinecke Cc: Christoph Hellwig , James Bottomley , linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, Dan Williams List-Id: linux-ide@vger.kernel.org Hello, On Sat, Sep 06, 2014 at 10:21:51AM +0200, Hannes Reinecke wrote: > Well, yes, in principle. I was looking into that, too. > But then I figured that moving to ata_taskfile would be a major overhaul for > libsas, which would be quite beyond scope here. > And all for a puny little patch. Hmm? Just allocate a ata_taskfile stuct on stack when invoking the function. The change would be a lot smaller actually. Thanks. -- tejun