From: Tejun Heo <tj@kernel.org>
To: George Spelvin <linux@horizon.com>
Cc: linux-ide@vger.kernel.org, stevenhoneyman@gmail.com
Subject: Re: [PATCH] libata: Un-break ATA blacklist
Date: Tue, 7 Oct 2014 13:24:23 -0400 [thread overview]
Message-ID: <20141007172423.GA31328@mtj.dyndns.org> (raw)
In-Reply-To: <20141007112638.20944.qmail@ns.horizon.com>
On Tue, Oct 07, 2014 at 07:26:38AM -0400, George Spelvin wrote:
> lib/glob.c provides a new glob_match() function, with arguments in
> (pattern, string) order. It replaced a private function with arguments
> in (string, pattern) order, but I didn't swap the call site...
>
> The result was the entire ATA blacklist was effectively disabled.
>
> The lesson for today is "I f***ed up *how* badly *how* many months ago?",
> er, I mean "Nobody Tests RC Kernels On Legacy Hardware".
>
> This was not a subtle break, but it made it through an entire RC
> cycle unreported, presumably because all the people doing testing
> have full-featured hardware.
>
> (FWIW, the reason for the argument swap was because fnmatch() does it that
> way, and for a while implementing a full fnmatch() was being considered.)
>
> Fixes: 428ac5fc056e0 (libata: Use glob_match from lib/glob.c)
> Reported-by: Steven Honeyman <stevenhoneyman@gmail.com>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=71371#c21
> Signed-off-by: George Spelvin <linux@horizon.com>
> Cc: <stable@vger.kernel.org> # 3.17
Oops, lol. Appiled to libata/for-3.17-fixes.
Thanks!
--
tejun
next prev parent reply other threads:[~2014-10-07 17:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 11:26 [PATCH] libata: Un-break ATA blacklist George Spelvin
2014-10-07 16:51 ` Steven Honeyman
2014-10-07 17:25 ` [urgent regression PATCH v2] " George Spelvin
2014-10-07 17:45 ` [PATCH] " George Spelvin
2014-10-07 17:24 ` Tejun Heo [this message]
2014-10-07 17:50 ` George Spelvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007172423.GA31328@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux@horizon.com \
--cc=stevenhoneyman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).