From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Ian Campbell <ijc-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH] ahci_sunxi: Drop AHCI_HFLAG_NO_PMP flag
Date: Thu, 13 Nov 2014 17:29:52 -0500 [thread overview]
Message-ID: <20141113222952.GI2598@htj.dyndns.org> (raw)
In-Reply-To: <1415874256-6580-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Thu, Nov 13, 2014 at 11:24:16AM +0100, Hans de Goede wrote:
> This is something which we inherited from the Allwinner android kernel sources,
> and I've always wanted to test if this is really necessary.
>
> So recently I've bought a sata port multiplexer, and I've given this a test
> spin on both A10 and A20 devices, and it seems to work fine:
>
> [ 2.154456] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> [ 2.161092] ata1.15: Port Multiplier 1.2, 0x197b:0x0325 r0, 5 ports, feat 0x5/0xf
> [ 2.175511] ata1.00: hard resetting link
> [ 2.524929] ata1.00: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
> [ 2.531430] ata1.01: hard resetting link
> [ 2.974465] ata1.01: link resume succeeded after 1 retries
> [ 3.094932] ata1.01: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> [ 3.101431] ata1.02: hard resetting link
> [ 4.174466] ata1.02: failed to resume link (SControl 0)
> [ 4.180065] ata1.02: SATA link down (SStatus 0 SControl 0)
> (and the same for links 3 and 4)
>
> Once the NO_PMP flag is removed it correctly sees the 2 disks which I've
> attached, and I can mount and use them just fine, so lets drop the flag.
>
> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Applied to libata/for-3.18-fixes.
Thanks.
--
tejun
next prev parent reply other threads:[~2014-11-13 22:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 10:24 [PATCH] ahci_sunxi: Drop AHCI_HFLAG_NO_PMP flag Hans de Goede
[not found] ` <1415874256-6580-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-11-13 22:29 ` Tejun Heo [this message]
[not found] ` <20141113222952.GI2598-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-11-14 11:56 ` Hans de Goede
[not found] ` <037f97ce-468b-4b91-9616-51a3301c5be6-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
2014-11-14 12:49 ` Hans de Goede
[not found] ` <5465FA40.8000508-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-11-14 13:08 ` Tejun Heo
2014-11-14 13:24 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113222952.GI2598@htj.dyndns.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=ijc-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).