From: Tejun Heo <tj@kernel.org>
To: nick <xerofoify@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Fix me in libata-scsi.c
Date: Tue, 2 Dec 2014 13:07:43 -0500 [thread overview]
Message-ID: <20141202180743.GI10918@htj.dyndns.org> (raw)
In-Reply-To: <546A9EAC.4080509@gmail.com>
On Mon, Nov 17, 2014 at 08:19:40PM -0500, nick wrote:
> I am wondering about the fix me in following code in the file listed
> in my message. Seems this is necessary from reading the code and the
> FIX ME is no longer needed as the memset is correct and needed for
> the function.
Yeah, I think the sense buffer clearing is the right thing regardless
of it being not strictly necessary for all devices. There's no point
in not clearing it. Please feel free to send a patch to remove the
comment.
Thanks.
--
tejun
parent reply other threads:[~2014-12-02 18:07 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <546A9EAC.4080509@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141202180743.GI10918@htj.dyndns.org \
--to=tj@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).