Re: Question about mv_print_info in sata_mv.c in sata_mv.c

Re: Question about mv_print_info in sata_mv.c in sata_mv.c

[Rob Herring]

On Mon, Dec 22, 2014 at 10:04 PM, nick <xerofoify@gmail.com> wrote:
> Greetings Tejuin,Grant and Rob,
> Hope you are having a good holidays. I am wondering if there is
> anything we need to add to this function as stated in a fix me above it.I am pretty certain
> there isn't but as the maintainers, I am double checking first with you:). Please let me
> known if you think of something.

Grant and I are not actually maintainers of this driver.
get_maintainer.pl is somewhat wrong here because it matches on regex
that is present in about every driver that is DT enabled. I've sent a
patch now to change that.

It would help also if you paste in the actually code you are referring to.

Rob

> Regards and Have a Great Holidays :),
> Nick

Re: Question about mv_print_info in sata_mv.c in sata_mv.c

[tj@kernel.org >> Tejun Heo]

Hello, Nick.

On Fri, Dec 26, 2014 at 04:06:11PM -0500, nick wrote:
> I am assuming after reading this function's code, that this function is completed and no longer
> needs a fix me comment above it to be completed.

I do appreciate that you're studying the FIXME comments but at this
point I'm not sure whether blindly chasing them and asking people
whether they're still necessary is a productive thing to do.  If
they're actively misleading, sure, let's remove them, but FIXME in a
sata_mv function which prints some controller identification
information just doesn't matter.  If you can assert that the comment
is no longer necessary and misleading, please submit a patch with
backing rationale; otherwise, obsessing with each instance of FIXME
comment doesn't seem to be a particularly productive way of
participating in kernel development.

Thanks.

-- 
tejun