From: Tejun Heo <tj@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mark Miesfeld <mmiesfeld@amcc.com>,
Jeff Garzik <jgarzik@redhat.com>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH v1 4/4] sata_dwc_460ex: fix most of the sparse warnings
Date: Wed, 7 Jan 2015 10:36:32 -0500 [thread overview]
Message-ID: <20150107153632.GD4395@htj.dyndns.org> (raw)
In-Reply-To: <1420637062-15450-4-git-send-email-andriy.shevchenko@linux.intel.com>
On Wed, Jan 07, 2015 at 03:24:22PM +0200, Andy Shevchenko wrote:
> There are a lot sparse warnings. Most of them related to __iomem keyword which
> sometimes absent when it's needed and vise versa.
>
> The patch fixes most of the warnings.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied 1-4 to libata/for-3.19-fixes. One nit below.
> @@ -1630,7 +1629,7 @@ static struct scsi_host_template sata_dwc_sht = {
> * max of 1. This will get fixed in in a future release.
> */
> .sg_tablesize = LIBATA_MAX_PRD,
> - .can_queue = ATA_DEF_QUEUE, /* ATA_MAX_QUEUE */
> + /* .can_queue = ATA_MAX_QUEUE, */
This part isn't explained by the patch description. I added it while
applying but please make sure that the patch descriptions are
comprehensive.
Thanks!
--
tejun
next prev parent reply other threads:[~2015-01-07 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 13:24 [PATCH v1 1/4] sata_dwc_460ex: fix resource leak on error path Andy Shevchenko
2015-01-07 13:24 ` [PATCH v1 2/4] sata_dwc_460ex: remove redundant dev_set_drvdata Andy Shevchenko
2015-01-07 13:24 ` [PATCH v1 3/4] sata_dwc_460ex: enable COMPILE_TEST for the driver Andy Shevchenko
2015-01-07 13:24 ` [PATCH v1 4/4] sata_dwc_460ex: fix most of the sparse warnings Andy Shevchenko
2015-01-07 15:36 ` Tejun Heo [this message]
2015-01-08 13:28 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150107153632.GD4395@htj.dyndns.org \
--to=tj@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jgarzik@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=mmiesfeld@amcc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).