* [PATCH] ahci: Use dev_info() to inform about the lack of Device Sleep support
@ 2015-01-08 18:41 Gabriele Mazzotta
2015-01-09 21:54 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Gabriele Mazzotta @ 2015-01-08 18:41 UTC (permalink / raw)
To: tj; +Cc: linux-ide, linux-kernel, Gabriele Mazzotta
According to the Serial ATA AHCI specification, Device Sleep is an
optional feature and as such no errors should be printed if it's
missing. Keep informing users, but use dev_info() instead of dev_err().
Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
---
drivers/ata/libahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index 97683e4..61a9c07 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -2003,7 +2003,7 @@ static void ahci_set_aggressive_devslp(struct ata_port *ap, bool sleep)
devslp = readl(port_mmio + PORT_DEVSLP);
if (!(devslp & PORT_DEVSLP_DSP)) {
- dev_err(ap->host->dev, "port does not support device sleep\n");
+ dev_info(ap->host->dev, "port does not support device sleep\n");
return;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ahci: Use dev_info() to inform about the lack of Device Sleep support
2015-01-08 18:41 [PATCH] ahci: Use dev_info() to inform about the lack of Device Sleep support Gabriele Mazzotta
@ 2015-01-09 21:54 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2015-01-09 21:54 UTC (permalink / raw)
To: Gabriele Mazzotta; +Cc: linux-ide, linux-kernel
On Thu, Jan 08, 2015 at 07:41:34PM +0100, Gabriele Mazzotta wrote:
> According to the Serial ATA AHCI specification, Device Sleep is an
> optional feature and as such no errors should be printed if it's
> missing. Keep informing users, but use dev_info() instead of dev_err().
Does this condition actually occur? The cap's advertise that the
controller does DEVSLP but the port register doesn't have it?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-09 21:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-08 18:41 [PATCH] ahci: Use dev_info() to inform about the lack of Device Sleep support Gabriele Mazzotta
2015-01-09 21:54 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).