From: Tejun Heo <tj@kernel.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
linux-ide@vger.kernel.org,
Ronny Hegewald <Ronny.Hegewald@online.de>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] libata: allow sata_sil24 to opt-out of tag ordered submission
Date: Mon, 19 Jan 2015 09:12:49 -0500 [thread overview]
Message-ID: <20150119141249.GA8140@htj.dyndns.org> (raw)
In-Reply-To: <54BA409E.4040901@cogentembedded.com>
On Sat, Jan 17, 2015 at 01:59:42PM +0300, Sergei Shtylyov wrote:
> > for (i = 0, tag = ap->last_tag + 1; i < max_queue; i++, tag++) {
> >- tag = tag < max_queue ? tag : 0;
> >+ if (ap->flags & ATA_FLAG_LOWTAG)
> >+ tag = i;
> >+ else
> >+ tag = tag < max_queue ? tag : 0;
>
> Ugh, this is clear abuse of the ?: operator... Why not simply:
>
> else if (tag >= max_queue)
> tag = 0;
Why is that a clear abuse? Seems like a pretty typical use to me.
Thanks.
--
tejun
next prev parent reply other threads:[~2015-01-19 14:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 23:12 [PATCH 0/2] fix sil24 regression and muddy the ata tag allocation waters Dan Williams
2015-01-16 23:13 ` [PATCH 1/2] libata: allow sata_sil24 to opt-out of tag ordered submission Dan Williams
2015-01-17 10:59 ` Sergei Shtylyov
[not found] ` <CAPcyv4h3n+cnvADiEbGgi1EFCqEwhzZ7gt_6XUmSC62aOf2Dzw@mail.gmail.com>
2015-01-17 18:43 ` Sergei Shtylyov
2015-01-19 14:12 ` Tejun Heo [this message]
2015-01-19 14:24 ` Sergei Shtylyov
2015-01-19 14:27 ` Tejun Heo
2015-01-19 14:13 ` Tejun Heo
2015-01-16 23:13 ` [PATCH 2/2] libata: micro-optimize tag allocation Dan Williams
2015-01-16 23:17 ` Jens Axboe
2015-01-16 23:19 ` Dan Williams
2015-01-16 23:21 ` Jens Axboe
2015-01-16 23:38 ` Dan Williams
2015-01-16 23:31 ` Shaohua Li
2015-01-16 23:49 ` Dan Williams
2015-01-16 23:55 ` Shaohua Li
2015-01-16 23:59 ` Dan Williams
2015-01-17 0:10 ` Shaohua Li
2015-01-19 14:14 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150119141249.GA8140@htj.dyndns.org \
--to=tj@kernel.org \
--cc=Ronny.Hegewald@online.de \
--cc=dan.j.williams@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).