From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v4 00/11] scsi: fix module reference mismatch for scsi host Date: Tue, 20 Jan 2015 10:18:24 -0500 Message-ID: <20150120151824.GA8684@htj.dyndns.org> References: <1421593569-5089-1-git-send-email-akinobu.mita@gmail.com> <20150119142206.GE8140@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-qc0-f180.google.com ([209.85.216.180]:41621 "EHLO mail-qc0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752442AbbATPS3 (ORCPT ); Tue, 20 Jan 2015 10:18:29 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Akinobu Mita Cc: "linux-scsi@vger.kernel.org" , Vinayak Holikatti , Dolev Raviv , Sujit Reddy Thumma , Subhash Jadavani , Matthew Dharm , Greg Kroah-Hartman , Alan Stern , "David S. Miller" , Hannes Reinecke , Hans de Goede , Mike Christie , Karen Xie , Robert Love , Christoph Hellwig , "James E.J. Bottomley" , open-iscsi@googlegroups.com, fcoe-devel@open-fcoe.org, linux-ide@vger.kernel.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net Hello, Akinobu. On Tue, Jan 20, 2015 at 11:57:37PM +0900, Akinobu Mita wrote: > The reason I didn't move sht from the core driver to the LLDDs for > fixing ufs and ums-* in the first place is to avoid exporting many > symbols for callbacks in sht. But I realized that we can do it > without that many exported symbols by creating a single function that > returns a kmemdup()ed sht with a few change including ->module. Hmmm, libata already exports most of the necessary symbols. libahci or platform drivers might have to export more but that shouldn't be much. For libata, pushing sht's to the leaf drivers would make far more sense as sht's already get inherited and modified along the hierarchy. Thanks. -- tejun