From: Nicholas Mc Guire <der.herr@hofr.at>
To: Joe Perches <joe@perches.com>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
"David S. Miller" <davem@davemloft.net>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ide_tape: convert jiffies with jiffies_to_msecs
Date: Tue, 3 Mar 2015 12:35:54 +0100 [thread overview]
Message-ID: <20150303113554.GA8142@opentech.at> (raw)
In-Reply-To: <1425380684.17273.13.camel@perches.com>
On Tue, 03 Mar 2015, Joe Perches wrote:
> On Tue, 2015-03-03 at 11:57 +0100, Nicholas Mc Guire wrote:
> > On Tue, 03 Mar 2015, Joe Perches wrote:
> > > On Tue, 2015-03-03 at 05:23 -0500, Nicholas Mc Guire wrote:
> > > > Note that this patch will give a checkpatch warning due to "quoted string
> > > > split across lines" but thats not related to this change - not sure if this
> > > > should be fixed - looks intentional to me.
> > >
> > > It's not. It'd be better coalesced.
> >
> > well it did seem quite systematic in this file, aside from it also needing
> > to move over the pr_* so thats going to need a few seperate cleanups.
>
> Sure, no worries, whenever/ifever.
>
> I'm pretty sure there aren't many active users
> of ide-tape devices.
>
Im sure thats true - the motivation for cleanups though is that what ever
stays in old drivers - even if hardly in use- gets copied into new drivers
at some point...
thx!
hofrat
prev parent reply other threads:[~2015-03-03 11:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 10:23 [PATCH] ide_tape: convert jiffies with jiffies_to_msecs Nicholas Mc Guire
2015-03-03 10:37 ` Joe Perches
2015-03-03 10:57 ` Nicholas Mc Guire
2015-03-03 11:04 ` Joe Perches
2015-03-03 11:35 ` Nicholas Mc Guire [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150303113554.GA8142@opentech.at \
--to=der.herr@hofr.at \
--cc=davem@davemloft.net \
--cc=hofrat@osadl.org \
--cc=joe@perches.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).