From: Tejun Heo <tj@kernel.org>
To: Quentin Lambert <lambert.quentin@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Mikael Pettersson <mikpelinux@gmail.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ata: remove deprecated use of pci api
Date: Wed, 8 Apr 2015 10:57:04 -0400 [thread overview]
Message-ID: <20150408145704.GL10582@htj.duckdns.org> (raw)
In-Reply-To: <1428496450-11244-1-git-send-email-lambert.quentin@gmail.com>
On Wed, Apr 08, 2015 at 02:34:10PM +0200, Quentin Lambert wrote:
> Replace occurences of the pci api by appropriate call to the dma api.
>
> A simplified version of the semantic patch that finds this problem is as
> follows: (http://coccinelle.lip6.fr)
>
> @deprecated@
> idexpression id;
> position p;
> @@
>
> (
> pci_dma_supported@p ( id, ...)
> |
> pci_alloc_consistent@p ( id, ...)
> )
>
> @bad1@
> idexpression id;
> position deprecated.p;
> @@
> ...when != &id->dev
> when != pci_get_drvdata ( id )
> when != pci_enable_device ( id )
> (
> pci_dma_supported@p ( id, ...)
> |
> pci_alloc_consistent@p ( id, ...)
> )
>
> @depends on !bad1@
> idexpression id;
> expression direction;
> position deprecated.p;
> @@
>
> (
> - pci_dma_supported@p ( id,
> + dma_supported ( &id->dev,
> ...
> + , GFP_ATOMIC
> )
> |
> - pci_alloc_consistent@p ( id,
> + dma_alloc_coherent ( &id->dev,
> ...
> + , GFP_ATOMIC
> )
> )
>
> Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Applied to libata/for-4.1. Thanks.
--
tejun
prev parent reply other threads:[~2015-04-08 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 12:34 [PATCH] ata: remove deprecated use of pci api Quentin Lambert
2015-04-08 14:57 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408145704.GL10582@htj.duckdns.org \
--to=tj@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lambert.quentin@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpelinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).