From: Dan Carpenter <dan.carpenter@oracle.com>
To: Quentin Lambert <lambert.quentin@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] ide: replace GFP_ATOMIC by GFP_KERNEL
Date: Thu, 9 Apr 2015 17:40:36 +0300 [thread overview]
Message-ID: <20150409144036.GB16501@mwanda> (raw)
In-Reply-To: <55268DCB.3010201@gmail.com>
On Thu, Apr 09, 2015 at 04:33:47PM +0200, Quentin Lambert wrote:
>
>
> On 09/04/2015 14:36, Dan Carpenter wrote:
> >Oh. They're not GFP_ATOMIC.
> >
> >Fold these two patches together into one patch and resend.
> The reason I did it that way is because I feel that the two patches
> really are different.
> The first one do not change the execution of the code but the second
> one does.
> Could you explain to me why they can be folded into one ?
When I read the first patch it left me with unanswered questions and I
was planning to ask you to redo it. After you had fixed 1/1 there is no
need for 2/2.
regards,
dan carpenter
next prev parent reply other threads:[~2015-04-09 14:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 11:46 [PATCH 0/2] pci to dma Quentin Lambert
2015-04-09 11:46 ` [PATCH 1/2] ide: remove deprecated use of pci api Quentin Lambert
2015-04-09 12:35 ` Dan Carpenter
2015-04-13 12:25 ` One Thousand Gnomes
2015-04-13 17:08 ` David Miller
2015-04-13 17:23 ` Dan Carpenter
2015-04-13 17:39 ` David Miller
2015-04-09 11:46 ` [PATCH 2/2] ide: replace GFP_ATOMIC by GFP_KERNEL Quentin Lambert
2015-04-09 12:36 ` Dan Carpenter
2015-04-09 14:33 ` Quentin Lambert
2015-04-09 14:40 ` Dan Carpenter [this message]
2015-04-09 14:50 ` Dan Carpenter
2015-04-09 14:51 ` Quentin Lambert
2015-04-09 14:53 ` Julia Lawall
2015-04-09 15:13 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150409144036.GB16501@mwanda \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=lambert.quentin@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).