From: Tejun Heo <tj@kernel.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Ronny Hegewald <ronny.hegewald@online.de>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] resolve collision of generic ATA_FLAG_LOWTAG and driver specific flag
Date: Mon, 13 Apr 2015 11:29:17 -0400 [thread overview]
Message-ID: <20150413152917.GE2596@htj.duckdns.org> (raw)
In-Reply-To: <5528007D.1080703@cogentembedded.com>
On Fri, Apr 10, 2015 at 07:55:25PM +0300, Sergei Shtylyov wrote:
> >>- SIL24_FLAG_PCIX_IRQ_WOC = (1 << 24), /* IRQ loss errata on PCI-X */
> >>+ SIL24_FLAG_PCIX_IRQ_WOC = (1 << 25), /* IRQ loss errata on PCI-X */
>
> This one also collides with ATA_FLAG_SAS_HOST.
>
> >And this will clash as soon as the next flag is added. Please don't
> >abuse the common flag space for driver specific ones, and add a separate
> >flags field for driver specific flags.
>
> Actually, bits 24-31 are reserved for the low-level driver usage (see the
> comment below ATA_FLAG_*), so it's the new ATA_FLAG_LOWTAG and
> ATA_FLAG_SAS_HOST that have violated the convention and should be moved
> (there's plenty of lower bits due to the removal of some obsolete flags).
Yeah, this something dumb I did way back. Can we please add a
separate field for per-controller flags in port_info and all related
structs so that we don't do this sharing?
Thanks.
--
tejun
next prev parent reply other threads:[~2015-04-13 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 20:09 [PATCH] resolve collision of generic ATA_FLAG_LOWTAG and driver specific flag Ronny Hegewald
2015-04-10 11:15 ` Christoph Hellwig
2015-04-10 16:55 ` Sergei Shtylyov
2015-04-13 15:29 ` Tejun Heo [this message]
2015-04-10 17:02 ` Sergei Shtylyov
2015-04-15 22:56 ` Ronny Hegewald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150413152917.GE2596@htj.duckdns.org \
--to=tj@kernel.org \
--cc=hch@infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=ronny.hegewald@online.de \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).