linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: gnomes@lxorguk.ukuu.org.uk, lambert.quentin@gmail.com,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] ide: remove deprecated use of pci api
Date: Mon, 13 Apr 2015 20:23:24 +0300	[thread overview]
Message-ID: <20150413172324.GZ10964@mwanda> (raw)
In-Reply-To: <20150413.130813.2058573928379941715.davem@davemloft.net>

On Mon, Apr 13, 2015 at 01:08:13PM -0400, David Miller wrote:
> From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
> Date: Mon, 13 Apr 2015 13:25:30 +0100
> 
> > On Thu,  9 Apr 2015 13:46:27 +0200
> > Quentin Lambert <lambert.quentin@gmail.com> wrote:
> > 
> >> Replace occurences of the pci api by appropriate call to the dma api.
> >> 
> > 
> > Drivers/ide is obsolete. It probably ought to go at this point but even
> > so it exists solely in case of a problem or compatibility issue with
> > drivers/ata. Cleaning it up without testing all the drivers makes no
> > sense IMHO. Cleaning it up and testing them doesn't make much sense
> > either.
> 
> It's a straightforward transformation, that actually evaluates to what
> the definitions of the deprecated pci DMA interfaces are defined to.

Almost, except that it uses GFP_KERNEL instead of GFP_DMA.  But I
reviewed it and I think it's fine. Quentin sent a GFP_ATOMIC patch as
the first version and I asked him to redo it.  Maybe I shouldn't have
done that...

regards,
dan carpenter


  reply	other threads:[~2015-04-13 17:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09 11:46 [PATCH 0/2] pci to dma Quentin Lambert
2015-04-09 11:46 ` [PATCH 1/2] ide: remove deprecated use of pci api Quentin Lambert
2015-04-09 12:35   ` Dan Carpenter
2015-04-13 12:25   ` One Thousand Gnomes
2015-04-13 17:08     ` David Miller
2015-04-13 17:23       ` Dan Carpenter [this message]
2015-04-13 17:39         ` David Miller
2015-04-09 11:46 ` [PATCH 2/2] ide: replace GFP_ATOMIC by GFP_KERNEL Quentin Lambert
2015-04-09 12:36   ` Dan Carpenter
2015-04-09 14:33     ` Quentin Lambert
2015-04-09 14:40       ` Dan Carpenter
2015-04-09 14:50       ` Dan Carpenter
2015-04-09 14:51         ` Quentin Lambert
2015-04-09 14:53         ` Julia Lawall
2015-04-09 15:13           ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150413172324.GZ10964@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lambert.quentin@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).