From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH 1/2] ide: remove deprecated use of pci api Date: Mon, 13 Apr 2015 20:23:24 +0300 Message-ID: <20150413172324.GZ10964@mwanda> References: <1428579988-10167-1-git-send-email-lambert.quentin@gmail.com> <1428579988-10167-2-git-send-email-lambert.quentin@gmail.com> <20150413132530.210f1d3b@lxorguk.ukuu.org.uk> <20150413.130813.2058573928379941715.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:40617 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754074AbbDMRXk (ORCPT ); Mon, 13 Apr 2015 13:23:40 -0400 Content-Disposition: inline In-Reply-To: <20150413.130813.2058573928379941715.davem@davemloft.net> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: David Miller Cc: gnomes@lxorguk.ukuu.org.uk, lambert.quentin@gmail.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Mon, Apr 13, 2015 at 01:08:13PM -0400, David Miller wrote: > From: One Thousand Gnomes > Date: Mon, 13 Apr 2015 13:25:30 +0100 > > > On Thu, 9 Apr 2015 13:46:27 +0200 > > Quentin Lambert wrote: > > > >> Replace occurences of the pci api by appropriate call to the dma api. > >> > > > > Drivers/ide is obsolete. It probably ought to go at this point but even > > so it exists solely in case of a problem or compatibility issue with > > drivers/ata. Cleaning it up without testing all the drivers makes no > > sense IMHO. Cleaning it up and testing them doesn't make much sense > > either. > > It's a straightforward transformation, that actually evaluates to what > the definitions of the deprecated pci DMA interfaces are defined to. Almost, except that it uses GFP_KERNEL instead of GFP_DMA. But I reviewed it and I think it's fine. Quentin sent a GFP_ATOMIC patch as the first version and I asked him to redo it. Maybe I shouldn't have done that... regards, dan carpenter