From: Ronny Hegewald <ronny.hegewald@online.de>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] resolve collision of generic ATA_FLAG_LOWTAG and driver specific flag
Date: Wed, 15 Apr 2015 22:56:50 +0000 [thread overview]
Message-ID: <201504152256.50452.ronny.hegewald@online.de> (raw)
In-Reply-To: <55280213.9000601@cogentembedded.com>
On Friday 10 April 2015, you wrote
> Actually, ATA_FLAG_LOWTAG has been removed in the 'for-next' branch, so
> this patch is no longer needed.
Its still needed for kernel <= 3.19, else the driver will malfunction for
SI3132 based chipsets.
> Moreover, the newly assigned flag clashes with the new ATA_FLAG_SATA_PORT.
As far i can tell its not really a problem in practice for this driver, as
they will not be used together. But its certainly better to keep the flags
clash-free nonetheless. I will change it to bit 31 in the next version of the
patch.
prev parent reply other threads:[~2015-04-15 22:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 20:09 [PATCH] resolve collision of generic ATA_FLAG_LOWTAG and driver specific flag Ronny Hegewald
2015-04-10 11:15 ` Christoph Hellwig
2015-04-10 16:55 ` Sergei Shtylyov
2015-04-13 15:29 ` Tejun Heo
2015-04-10 17:02 ` Sergei Shtylyov
2015-04-15 22:56 ` Ronny Hegewald [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201504152256.50452.ronny.hegewald@online.de \
--to=ronny.hegewald@online.de \
--cc=linux-ide@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).