* [PATCH] ata: pmp: add quirk for Marvell 4140 SATA PMP
@ 2015-06-30 14:09 Thomas Petazzoni
2015-07-14 21:46 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Petazzoni @ 2015-06-30 14:09 UTC (permalink / raw)
To: Tejun Heo, linux-ide
Cc: Tawfik Bayouk, Nadav Haklai, Lior Amsalem, Gregory Clement,
Thomas Petazzoni
From: Lior Amsalem <alior@marvell.com>
This commit adds the necessary quirk to make the Marvell 4140 SATA PMP
work properly. This PMP doesn't like SRST on port number 4 (the host
port) so this commit marks this port as not supporting SRST.
Signed-off-by: Lior Amsalem <alior@marvell.com>
Reviewed-by: Nadav Haklai <nadavh@marvell.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
drivers/ata/libata-pmp.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c
index 7ccc084..85aa761 100644
--- a/drivers/ata/libata-pmp.c
+++ b/drivers/ata/libata-pmp.c
@@ -460,6 +460,13 @@ static void sata_pmp_quirks(struct ata_port *ap)
ATA_LFLAG_NO_SRST |
ATA_LFLAG_ASSUME_ATA;
}
+ } else if (vendor == 0x11ab && devid == 0x4140) {
+ /* Marvell 4140 quirks */
+ ata_for_each_link(link, ap, EDGE) {
+ /* port 4 is for SEMB device and it doesn't like SRST */
+ if (link->pmp == 4)
+ link->flags |= ATA_LFLAG_DISABLED;
+ }
}
}
--
2.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ata: pmp: add quirk for Marvell 4140 SATA PMP
2015-06-30 14:09 [PATCH] ata: pmp: add quirk for Marvell 4140 SATA PMP Thomas Petazzoni
@ 2015-07-14 21:46 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2015-07-14 21:46 UTC (permalink / raw)
To: Thomas Petazzoni
Cc: linux-ide, Tawfik Bayouk, Nadav Haklai, Lior Amsalem,
Gregory Clement
On Tue, Jun 30, 2015 at 04:09:49PM +0200, Thomas Petazzoni wrote:
> From: Lior Amsalem <alior@marvell.com>
>
> This commit adds the necessary quirk to make the Marvell 4140 SATA PMP
> work properly. This PMP doesn't like SRST on port number 4 (the host
> port) so this commit marks this port as not supporting SRST.
>
> Signed-off-by: Lior Amsalem <alior@marvell.com>
> Reviewed-by: Nadav Haklai <nadavh@marvell.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Applied to libata/for-4.2-fixes w/ stable cc'd.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-14 21:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-30 14:09 [PATCH] ata: pmp: add quirk for Marvell 4140 SATA PMP Thomas Petazzoni
2015-07-14 21:46 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).