From: Tejun Heo <tj@kernel.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Arne Fitzenreiter <arne_f@ipfire.org>,
linux-ide@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] libata: add ATA_HORKAGE_NOTRIM
Date: Wed, 15 Jul 2015 13:53:57 -0400 [thread overview]
Message-ID: <20150715175357.GG15934@mtj.duckdns.org> (raw)
In-Reply-To: <55A69715.20901@cogentembedded.com>
Hello,
On Wed, Jul 15, 2015 at 08:23:33PM +0300, Sergei Shtylyov wrote:
> >@@ -431,6 +431,8 @@ enum {
> > ATA_HORKAGE_WD_BROKEN_LPM = (1 << 21), /* some WDs have broken LPM */
> > ATA_HORKAGE_ZERO_AFTER_TRIM = (1 << 22),/* guarantees zero after trim */
> > ATA_HORKAGE_NO_NCQ_LOG = (1 << 23), /* don't use NCQ for log read */
> >+ ATA_HORKAGE_NOTRIM = (1 << 24), /* don't use TRIM */
>
> BTW, why not ATA_HORKAGE_NO_TRIM like the others?
We actually have a bunch of NOXXX's. We prolly wanna clean them up
together later but things like this ultimately don't really matter.
> >+
>
> Empty line not needed here.
I removed it while merging a later patch.
Thanks.
--
tejun
next prev parent reply other threads:[~2015-07-15 17:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 11:54 [PATCH 0/2] disable trim for SuperSSpeed S238 SSD - v3 Arne Fitzenreiter
2015-07-15 11:54 ` [PATCH 1/2] libata: add ATA_HORKAGE_NOTRIM Arne Fitzenreiter
2015-07-15 14:26 ` Greg KH
2015-07-15 15:25 ` Tejun Heo
2015-07-15 17:23 ` Sergei Shtylyov
2015-07-15 17:53 ` Tejun Heo [this message]
2015-07-15 11:54 ` [PATCH 2/2] libata: force disable trim for SuperSSpeed S238 Arne Fitzenreiter
2015-07-15 14:26 ` Greg KH
2015-07-15 15:26 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2015-07-14 13:01 [PATCH 0/2] disable trim for SuperSSpeed S238 SSD - v2 Arne Fitzenreiter
2015-07-14 13:01 ` [PATCH 1/2] libata: add ATA_HORKAGE_NOTRIM Arne Fitzenreiter
2015-07-14 11:28 [PATCH 0/2] disable trim for SuperSSpeed S238 SSD Arne Fitzenreiter
2015-07-14 11:28 ` [PATCH 1/2] libata: add ATA_HORKAGE_NOTRIM Arne Fitzenreiter
2015-07-14 11:43 ` Sergei Shtylyov
2015-07-14 12:16 ` arne_f
2015-07-14 12:34 ` Sergei Shtylyov
2015-07-14 18:50 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715175357.GG15934@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=arne_f@ipfire.org \
--cc=linux-ide@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).